Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Explicitly handle if the discriminator property value is null #988

Merged
merged 1 commit into from
Mar 16, 2024

Conversation

justin-tay
Copy link
Contributor

Closes #985

This makes changes such that a missing discriminator property is treated as if the discriminator is ignored.

This does not generate an assertion due to the missing discriminator property to be consistent with

@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 93.10345% with 2 lines in your changes are missing coverage. Please review.

Project coverage is 78.81%. Comparing base (0f983b0) to head (be2d8f9).

Files Patch % Lines
...main/java/com/networknt/schema/AnyOfValidator.java 80.00% 0 Missing and 1 partial ⚠️
...main/java/com/networknt/schema/OneOfValidator.java 94.73% 0 Missing and 1 partial ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@             Coverage Diff              @@
##             master     #988      +/-   ##
============================================
+ Coverage     78.76%   78.81%   +0.05%     
- Complexity     1919     1927       +8     
============================================
  Files           172      172              
  Lines          6197     6213      +16     
  Branches       1199     1205       +6     
============================================
+ Hits           4881     4897      +16     
  Misses          861      861              
  Partials        455      455              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@stevehu stevehu merged commit 6f44455 into networknt:master Mar 16, 2024
4 checks passed
@justin-tay justin-tay deleted the gh985 branch March 20, 2024 02:00
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bug: null test missing for missing discriminator property.
3 participants