-
Notifications
You must be signed in to change notification settings - Fork 745
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Fix huawei display acl all - port numbers replaced by names and IPV6 ACL name position #1222
Fix huawei display acl all - port numbers replaced by names and IPV6 ACL name position #1222
Conversation
9db06a5
to
103c2f1
Compare
Hey @itdependsnetworks, I noticed another problem with ACLs, and I am unsure how to best handle it: There are two types of object fetched by this template: the ACL, and a rule of an ACL.
We don't get it parsed. So I guess the broader problem is: Are we fetching ACL? Or only its rules? Or both (and how to do it) ? :) |
Yes, I think you should capture it, even if the rule is empty |
With the "rule description" being on an other line, the only solution I found was to first record each ACL name and number with empty rules values, then each rules. |
052f4b9
to
38484fc
Compare
38484fc
to
552efdc
Compare
…ACL name position (#1222) * Fix huawei display acl all - port numbers replaced by names * Fix Huawei - display acl (ipv6)? all - if name provided, order in IPv6 changes * Huawei - display acl all - add rule description * Huawei - display acl all - separately record ACLs and their rules authored-by: Edouard Lavaud <e.lavaud@unyc.io>
…ACL name position (networktocode#1222) * Fix huawei display acl all - port numbers replaced by names * Fix Huawei - display acl (ipv6)? all - if name provided, order in IPv6 changes * Huawei - display acl all - add rule description * Huawei - display acl all - separately record ACLs and their rules authored-by: Edouard Lavaud <e.lavaud@unyc.io>
ISSUE TYPE
COMPONENT
Huawei VRP
display acl all
SUMMARY
First commit:
Huawei will automatically replace well known ports by their corresponding names. For example 80 by "www", or 23 by "telnet"
I also improved the test by adding a range of ports
Second commit:
When available, the position of the name change between IPv4 and IPv6.
Third commit:
ACL rules can have descriptions
Fourth commit:
Always record first the ACL with empty rules values, and then its rules. Otherwise it was not possible to record ACL that has no rules