Updated huawei_smartax display ont info #1704
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
so it matches other versions of the template. In certain edge cases was not working. For example with the model EA5608 was not matching correctly, because the output is slightly different. Now it works! Also added the noqa E231 exception in tasks.py as it is not passing the flake8 tests. Now they pass. The error is due to a detection of the : in side a string. It shouldn't be detected in that case but flake8 is detecting it.
evilmonkey19
requested review from
itdependsnetworks,
jmcgill298 and
jvanderaa
as code owners
jvanderaa
approved these changes
May 30, 2024
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The command
display ont info \S+template was not matching particular versions of the same command. The command is fairly similar except for tiny details. In certain edge cases was not working. For example with the model EA5608 was not matching correctly, because the output is slightly different. Now it works! Look at filetests/huawei_smartax/display_ont_info_fsp/huawei_smartax_display_ont_info_fsp_2.rawandtests/huawei_smartax/display_ont_info_fsp/huawei_smartax_display_ont_info_fsp.rawAlso added the noqa E231 exception in tasks.py as it is not passing the flake8 tests. Now they pass. The error is due to a detection of the : in side a string. It shouldn't be detected in that case but flake8 is detecting it.