Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

bugfix - hp_comware_display_device_manuinfo #1805

Merged
merged 3 commits into from
Aug 5, 2024
Merged

bugfix - hp_comware_display_device_manuinfo #1805

merged 3 commits into from
Aug 5, 2024

Conversation

mjbear
Copy link
Contributor

@mjbear mjbear commented Aug 4, 2024 •
edited
Loading

resolves #1366
bugfix
breaking change?

  • Support HP devices that do not have a SLOT_TYPE (ex: WX2560X-LI)
  • (breaking change?) In removing the Required keyword from SLOT_TYPE it allows an extra Device Name entry which has no preceding Slot Type. (Will this extra entry break someone's script?)
  • Replace extra unnecessary state change: -> Record Start to -> Record
  • Override EOF State to avoid extra mostly empty match at the end of the list
  • Add and support raw output for HP 5200 router and 5930 switch

@mjbear mjbear mentioned this pull request Aug 4, 2024
Closed
@jmcgill298 jmcgill298 merged commit b3063ef into networktocode:master Aug 5, 2024
14 checks passed
@mjbear mjbear deleted the hp_comware_disp_dev_manuinfo_issue1366 branch August 5, 2024 15:51
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@jmcgill298 jmcgill298 jmcgill298 approved these changes

@itdependsnetworks itdependsnetworks Awaiting requested review from itdependsnetworks itdependsnetworks is a code owner

@jvanderaa jvanderaa Awaiting requested review from jvanderaa jvanderaa is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Issue:hp_comware, display device manuinfo
2 participants
@mjbear @jmcgill298