Fix Mikrotik's '/ip neighbor print detail' template #1808
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PavloSkliarenko
requested review from
itdependsnetworks,
jmcgill298 and
jvanderaa
as code owners
jmcgill298
requested changes
Aug 8, 2024
Comment on lines
43
to
44
| # ^\s*(?:${NUMBER})?(?:\s+interface=${INTERFACE})?(?:\s+address=${IP_ADDRESS})?(?:\s+address4=${IPV4_ADDRESS})?(?:\s+address6=${IPV6_ADDRESS})?(?:\s+mac-address=${MAC_ADDRESS})?(:?\s+identity="${IDENTITY}")?(?:\s+platform="${PLATFORM}")?(?:\s+version="${VERSION}")?(:?\s+unpack=${UNPACK})?(?:\s+age=${AGE})?(?:\s+uptime=${UPTIME})?(?:\s+software-id="${SOFTWARE_ID}")?(?:\s+board="${BOARD}")?(?:\s+ipv6=${IPV6})?(?:\s+interface-name="${INTERFACE_NAME}")?(?:\s+system-description="${SYSTEM_DESCRIPTION}")?(?:\s+system-caps="?${SYSTEM_CAPS}"?)?(:?\s+system-caps-enabled="?${SYSTEM_CAPS_ENABLED}"?)?\s*$$ | ||
| # ^. -> Error |
There was a problem hiding this comment.
Suggested change
| # ^\s*(?:${NUMBER})?(?:\s+interface=${INTERFACE})?(?:\s+address=${IP_ADDRESS})?(?:\s+address4=${IPV4_ADDRESS})?(?:\s+address6=${IPV6_ADDRESS})?(?:\s+mac-address=${MAC_ADDRESS})?(:?\s+identity="${IDENTITY}")?(?:\s+platform="${PLATFORM}")?(?:\s+version="${VERSION}")?(:?\s+unpack=${UNPACK})?(?:\s+age=${AGE})?(?:\s+uptime=${UPTIME})?(?:\s+software-id="${SOFTWARE_ID}")?(?:\s+board="${BOARD}")?(?:\s+ipv6=${IPV6})?(?:\s+interface-name="${INTERFACE_NAME}")?(?:\s+system-description="${SYSTEM_DESCRIPTION}")?(?:\s+system-caps="?${SYSTEM_CAPS}"?)?(:?\s+system-caps-enabled="?${SYSTEM_CAPS_ENABLED}"?)?\s*$$ | |
| # ^. -> Error | |
| ^\s*$$ | |
| ^. -> Error |
We still need to account for missing data
jmcgill298
approved these changes
Aug 9, 2024
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.