New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

support for case of unassigned ipv6 address as chassis ID #1887

Merged

jmcgill298 merged 28 commits into networktocode:master from mcn29:fix_ios_lldp_nei_detail

Oct 29, 2024

Contributor

mcn29 commented Oct 28, 2024 •

edited

Loading

The CHASSIS_ID value :: is shown by IOS XE when the remote device uses its IPv6 address as the chassis ID but has no address assigned.

This change prevents the template from throwing an error as soon as it encounters the : character in this peculiar use case


          case unassigned ipv6 address as chassis ID

d8cddea

mcn29 requested review from itdependsnetworks, jmcgill298 and jvanderaa as code owners

October 28, 2024 20:21

jmcgill298 requested changes

View reviewed changes

Contributor

jmcgill298 left a comment

Thanks @mcn29 , just a couple of minor changes

tests/cisco_ios/show_lldp_neighbors_detail/cisco_ios_show_lldp_neighbors_detail6.raw Outdated Show resolved Hide resolved

tests/cisco_ios/show_lldp_neighbors_detail/cisco_ios_show_lldp_neighbors_detail6.yml Outdated Show resolved Hide resolved

tests/cisco_ios/show_lldp_neighbors_detail/cisco_ios_show_lldp_neighbors_detail6.yml Outdated Show resolved Hide resolved

mcn29 and others added 2 commits

October 28, 2024 21:36


          Update tests/cisco_ios/show_lldp_neighbors_detail/cisco_ios_show_lldp…

0d5f247

…_neighbors_detail6.raw

Co-authored-by: Jacob McGill <9847006+jmcgill298@users.noreply.github.com>


          Update tests/cisco_ios/show_lldp_neighbors_detail/cisco_ios_show_lldp…

851ddb4

…_neighbors_detail6.yml

Co-authored-by: Jacob McGill <9847006+jmcgill298@users.noreply.github.com>

Contributor

mjbear commented Oct 28, 2024

resolves #1884

mjbear suggested changes

View reviewed changes

tests/cisco_ios/show_lldp_neighbors_detail/cisco_ios_show_lldp_neighbors_detail6.yml Show resolved Hide resolved

tests/cisco_ios/show_lldp_neighbors_detail/cisco_ios_show_lldp_neighbors_detail6.yml Outdated Show resolved Hide resolved

tests/cisco_ios/show_lldp_neighbors_detail/cisco_ios_show_lldp_neighbors_detail6.yml Outdated Show resolved Hide resolved

tests/cisco_ios/show_lldp_neighbors_detail/cisco_ios_show_lldp_neighbors_detail6.yml Outdated Show resolved Hide resolved

tests/cisco_ios/show_lldp_neighbors_detail/cisco_ios_show_lldp_neighbors_detail6.yml Outdated Show resolved Hide resolved

tests/cisco_ios/show_lldp_neighbors_detail/cisco_ios_show_lldp_neighbors_detail6.yml Outdated Show resolved Hide resolved

tests/cisco_ios/show_lldp_neighbors_detail/cisco_ios_show_lldp_neighbors_detail6.yml Outdated Show resolved Hide resolved

tests/cisco_ios/show_lldp_neighbors_detail/cisco_ios_show_lldp_neighbors_detail6.yml Outdated Show resolved Hide resolved

tests/cisco_ios/show_lldp_neighbors_detail/cisco_ios_show_lldp_neighbors_detail6.yml Outdated Show resolved Hide resolved

tests/cisco_ios/show_lldp_neighbors_detail/cisco_ios_show_lldp_neighbors_detail6.yml Outdated Show resolved Hide resolved

mcn29 and others added 21 commits

October 29, 2024 13:47


          Update tests/cisco_ios/show_lldp_neighbors_detail/cisco_ios_show_lldp…

b12e0de

…_neighbors_detail6.yml

Co-authored-by: Michael Bear <38406045+mjbear@users.noreply.github.com>


          Update tests/cisco_ios/show_lldp_neighbors_detail/cisco_ios_show_lldp…

62d23e7

…_neighbors_detail6.yml

Co-authored-by: Michael Bear <38406045+mjbear@users.noreply.github.com>


          Update tests/cisco_ios/show_lldp_neighbors_detail/cisco_ios_show_lldp…

8a90914

…_neighbors_detail6.yml

Co-authored-by: Michael Bear <38406045+mjbear@users.noreply.github.com>


          Update tests/cisco_ios/show_lldp_neighbors_detail/cisco_ios_show_lldp…

344ec58

…_neighbors_detail6.yml

Co-authored-by: Michael Bear <38406045+mjbear@users.noreply.github.com>


          Update tests/cisco_ios/show_lldp_neighbors_detail/cisco_ios_show_lldp…

81c7321

…_neighbors_detail6.yml

Co-authored-by: Michael Bear <38406045+mjbear@users.noreply.github.com>


          Update tests/cisco_ios/show_lldp_neighbors_detail/cisco_ios_show_lldp…

9d7b18c

…_neighbors_detail6.yml

Co-authored-by: Michael Bear <38406045+mjbear@users.noreply.github.com>


          Update tests/cisco_ios/show_lldp_neighbors_detail/cisco_ios_show_lldp…

163c99d

…_neighbors_detail6.yml

Co-authored-by: Michael Bear <38406045+mjbear@users.noreply.github.com>


          Update tests/cisco_ios/show_lldp_neighbors_detail/cisco_ios_show_lldp…

778d0da

…_neighbors_detail6.yml

Co-authored-by: Michael Bear <38406045+mjbear@users.noreply.github.com>


          Update tests/cisco_ios/show_lldp_neighbors_detail/cisco_ios_show_lldp…

cf1c960

…_neighbors_detail6.yml

Co-authored-by: Michael Bear <38406045+mjbear@users.noreply.github.com>


          Update tests/cisco_ios/show_lldp_neighbors_detail/cisco_ios_show_lldp…

b45916b

…_neighbors_detail6.yml

Co-authored-by: Michael Bear <38406045+mjbear@users.noreply.github.com>


          Update tests/cisco_ios/show_lldp_neighbors_detail/cisco_ios_show_lldp…

150f734

…_neighbors_detail6.yml

Co-authored-by: Michael Bear <38406045+mjbear@users.noreply.github.com>


          Update tests/cisco_ios/show_lldp_neighbors_detail/cisco_ios_show_lldp…

83738a7

…_neighbors_detail6.yml

Co-authored-by: Michael Bear <38406045+mjbear@users.noreply.github.com>


          Update tests/cisco_ios/show_lldp_neighbors_detail/cisco_ios_show_lldp…

24309fa

…_neighbors_detail6.yml

Co-authored-by: Michael Bear <38406045+mjbear@users.noreply.github.com>


          Update tests/cisco_ios/show_lldp_neighbors_detail/cisco_ios_show_lldp…

a8ea3c4

…_neighbors_detail6.yml

Co-authored-by: Michael Bear <38406045+mjbear@users.noreply.github.com>


          Update tests/cisco_ios/show_lldp_neighbors_detail/cisco_ios_show_lldp…

f107bc1

…_neighbors_detail6.yml

Co-authored-by: Michael Bear <38406045+mjbear@users.noreply.github.com>


          Update tests/cisco_ios/show_lldp_neighbors_detail/cisco_ios_show_lldp…

ac2f0b6

…_neighbors_detail6.yml

Co-authored-by: Michael Bear <38406045+mjbear@users.noreply.github.com>


          Update tests/cisco_ios/show_lldp_neighbors_detail/cisco_ios_show_lldp…

b0265fa

…_neighbors_detail6.yml

Co-authored-by: Michael Bear <38406045+mjbear@users.noreply.github.com>


          Update tests/cisco_ios/show_lldp_neighbors_detail/cisco_ios_show_lldp…

f446ffc

…_neighbors_detail6.yml

Co-authored-by: Michael Bear <38406045+mjbear@users.noreply.github.com>


          Update tests/cisco_ios/show_lldp_neighbors_detail/cisco_ios_show_lldp…

42031ff

…_neighbors_detail6.yml

Co-authored-by: Michael Bear <38406045+mjbear@users.noreply.github.com>


          Update tests/cisco_ios/show_lldp_neighbors_detail/cisco_ios_show_lldp…

88a48db

…_neighbors_detail6.yml

Co-authored-by: Michael Bear <38406045+mjbear@users.noreply.github.com>


          Update tests/cisco_ios/show_lldp_neighbors_detail/cisco_ios_show_lldp…

eabbf15

…_neighbors_detail6.yml

Co-authored-by: Michael Bear <38406045+mjbear@users.noreply.github.com>


          Update tests/cisco_ios/show_lldp_neighbors_detail/cisco_ios_show_lldp…

7a3defb

…_neighbors_detail6.yml

Co-authored-by: Michael Bear <38406045+mjbear@users.noreply.github.com>

jmcgill298 approved these changes

View reviewed changes

jmcgill298 reviewed

View reviewed changes

tests/cisco_ios/show_lldp_neighbors_detail/cisco_ios_show_lldp_neighbors_detail6.yml Outdated Show resolved Hide resolved


          Update tests/cisco_ios/show_lldp_neighbors_detail/cisco_ios_show_lldp…

e2fb991

…_neighbors_detail6.yml

jmcgill298 reviewed

View reviewed changes

tests/cisco_ios/show_lldp_neighbors_detail/cisco_ios_show_lldp_neighbors_detail6.yml Outdated Show resolved Hide resolved


          Update tests/cisco_ios/show_lldp_neighbors_detail/cisco_ios_show_lldp…

30ea8ab

…_neighbors_detail6.yml

jmcgill298 reviewed

View reviewed changes

tests/cisco_ios/show_lldp_neighbors_detail/cisco_ios_show_lldp_neighbors_detail6.yml Outdated Show resolved Hide resolved


          Update tests/cisco_ios/show_lldp_neighbors_detail/cisco_ios_show_lldp…

7af1440

…_neighbors_detail6.yml

jmcgill298 merged commit 138e9d9 into networktocode:master

14 checks passed

Contributor

mjbear commented Oct 30, 2024

Thank you @jmcgill298! 🎆

# for free to join this conversation on GitHub. Already have an account? # to comment

Reviewers

jmcgill298 jmcgill298 approved these changes

mjbear mjbear requested changes

itdependsnetworks Awaiting requested review from itdependsnetworks itdependsnetworks is a code owner

jvanderaa Awaiting requested review from jvanderaa jvanderaa is a code owner

Labels

None yet