Alcatel aos show vlan port members #1899
Conversation
evilmonkey19
requested review from
itdependsnetworks,
jmcgill298 and
jvanderaa
as code owners
|
@evilmonkey19 Edit: Also, I have some suggestions once it is determined if this PR is split into two. Thank you. |
|
Fixed ✅ It was not intended but rather that i'm doing local development. |
ntc_templates/templates/index
Outdated
| @@ -11,6 +11,7 @@ | |||
| # | |||
| Template, Hostname, Platform, Command | |||
|
|
|||
| alcatel_aos_show_vlan_port.textfsm, .*, alcatel_aos, show vlan (port|members) | |||
There was a problem hiding this comment.
@evilmonkey19
Is it possible to have shorthand commands on the AOS command line?
ex: sh vl po
There was a problem hiding this comment.
Technically you can do sh vl po if you do tab after each command. However, I will add the possibility :)
| Value TYPE (default|qtagged) | ||
| Value STATUS (forwarding|inactive) |
There was a problem hiding this comment.
| Value TYPE (default|qtagged) | |
| Value STATUS (forwarding|inactive) | |
| Value TYPE (\S+) | |
| Value STATUS (\S+) |
Probably better to make the pattern more flexible for the long term.
In my testing using this pattern causes no ill effects with the test data.
There was a problem hiding this comment.
added suggestion! :)
| ^\s*--------+------------+------------+--------------*$$ | ||
| ^\s*------+-------+---------+-------------*$$ |
There was a problem hiding this comment.
| ^\s*--------+------------+------------+--------------*$$ | |
| ^\s*------+-------+---------+-------------*$$ | |
| ^\s*[-+]+\s*$$ |
Condense two separator lines into one.
Added accommodation for trailing white space with \s* just in case there's ever a trailing space or two.
If you support my suggestion, click the button here to accept my suggestion. Thank you. 😀
There was a problem hiding this comment.
I love it! Way cleaner and better :)
There was a problem hiding this comment.
General feedback here.
We/you could probably condense this 102 line file into about ten lines by picking lines with unique patterns.
Several duplicate lines with the same patterns do not add value.
(This is some wisdom I've learned while wading through long raw and structured files plus waiting for the test cases to run. 🤣)
There was a problem hiding this comment.
great suggestion! Added on the new commit :)
There was a problem hiding this comment.
Similar feedback to the previous raw output file.
Lots of the same duplicate lines don't add anything valuable to test against.
Example:
We'd be just fine with say one of these.
1 1/27 default inactive
1 1/28 default inactive
Apply that same thought to some of the other lines.
Please think about it. We can certainly continue the discussion. 😄
| @@ -0,0 +1,12 @@ | |||
| Value VLAN_ID (\d+) | |||
| Value PORT ((\d+\/)?\d+\/\d+) | |||
There was a problem hiding this comment.
| Value PORT ((\d+\/)?\d+\/\d+) | |
| Value PORT ((\d+\/?)+) |
This supports 1/1 and 1/1/1 ... plus more.
We can shorten this pattern quite a bit and even have the potential support 1/1/1/1 and beyond.
(Not that an interface would be named that anytime soon.)
There was a problem hiding this comment.
Also added this new suggestion :)
I doubt in the near future will see 1/1/1/1/1/1 but who knows xd
|
Thank you for the suggestions! Later whenever I have sometime during the evening-night i will read them carefully :) |
Adding new template