-
Notifications
You must be signed in to change notification settings - Fork 745
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Captured Administrative Mode, added support for unassigned Access VLAN #552
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@jmorello12 Please also update the test files in tests/cisco_ios/show_interfaces_switchport/
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Need to update regex to ensure trailing whitespace is stripped
@@ -3,7 +3,8 @@ Value SWITCHPORT (.+) | |||
Value SWITCHPORT_MONITOR (.+) | |||
Value SWITCHPORT_NEGOTIATION (.+) | |||
Value MODE (.+) | |||
Value ACCESS_VLAN (\d+) | |||
Value ADMIN_MODE (.+) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Value ADMIN_MODE (.+) | |
Value ADMIN_MODE (.+?) |
@@ -19,7 +20,7 @@ Start | |||
^\s*Trunking\s+Native\s+Mode\s+VLAN:\s+${NATIVE_VLAN} | |||
^\s*Voice\s+VLAN:\s+${VOICE_VLAN} | |||
^\s*Trunking\s+VLANs\s+Enabled:\s+${TRUNKING_VLANS} | |||
^\s*Administrative\s+Mode | |||
^\s*Administrative\s+Mode:\s+${ADMIN_MODE} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
^\s*Administrative\s+Mode:\s+${ADMIN_MODE} | |
^\s*Administrative\s+Mode:\s+${ADMIN_MODE}\s*$$ |
@jmorello12 Do you mind addressing @jmcgill298's feedback? We can get it merged in once the necessary changes are made. |
ISSUE TYPE
COMPONENT
Template: cisco_ios_show_interfaces_switchport.textfsm
OS: Cisco IOS
Command: show interfaces switchport
SUMMARY
Added a capture group for "Administrative Mode" and added support for the case where Access VLAN is unassigned.