Fixes for cisco_ios_show_running-config_partition_access-list template #598
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @jmcgill298 , Blame github reviewers suggestions hehe How do we get around this one? I added a missing/ignored capture group for tcp_flags. So even though it works backwards, people will get a new key/value pair on their dictionaries. |
|
Thanks @jpobeda |
thomasblass
pushed a commit
to thomasblass/ntc-templates
that referenced
this pull request
Oct 25, 2020
* Add Capture Group `TCP_FLAG` * Convert `COMMENT` to a List * Update `PROTOCOL` to include numbered protocols
jvanderaa
pushed a commit
that referenced
this pull request
Nov 10, 2021
* Add Capture Group `TCP_FLAG` * Convert `COMMENT` to a List * Update `PROTOCOL` to include numbered protocols
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ISSUE TYPE
COMPONENT
cisco_ios_show_running-config_partition_access-list.textfsm
cisco_ios
show running-config | section access-list
SUMMARY