Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

New Template added support for broadcom_icos_show_isdp_neighbors #748

Merged
merged 2 commits into from
Jun 6, 2020
Merged

Conversation

alepodj
Copy link
Contributor

@alepodj alepodj commented Jun 5, 2020

ISSUE TYPE
  • New Template Pull Request
COMPONENT

broadcom_icos_show_isdp_neighbors
broadcom_icos
show_isdp_neighbors

tox_broadcom_icos_show_isdp_neighbors.txt

# Accton AS4610-54P, Accton AS5610-52X, Quanta LY2R, Quanta LB9, DNI AG3448P-R
# Raw data is the same in the case of all those devices
^Capability\sCodes:
^\s+\S+
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
^\s+\S+
^\s+\S+\s+-

This narrows the scope to a match stricter to the possible capability codes.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Correction made

@FragmentedPacket FragmentedPacket added the changes_requested Waiting on user to address feedback label Jun 6, 2020
@FragmentedPacket FragmentedPacket merged commit 1f84282 into networktocode:master Jun 6, 2020
thomasblass pushed a commit to thomasblass/ntc-templates that referenced this pull request Oct 25, 2020
guillaume-mbali pushed a commit to unyc-io/ntc-templates that referenced this pull request Apr 12, 2023
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
changes_requested Waiting on user to address feedback
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants