Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Bugfix: cisco_ios_show_running_partition_access_list #808

Merged
merged 8 commits into from
Oct 26, 2020

Conversation

jpobeda
Copy link
Contributor

@jpobeda jpobeda commented Oct 3, 2020

ISSUE TYPE
  • Bugfix Pull Request
COMPONENT

cisco_ios_show_running_partition_access-list.textfsm
show running partition access-list

SUMMARY

Cisco IOS-XE outputs ACE line number on later versions.
Added Value LINE_NUM and made it backwards compatible.
Introduced Value ICMP_TYPE to amend capturing the icmp type eg: 'echo=reply'

@jpobeda
Copy link
Contributor Author

jpobeda commented Oct 3, 2020

@jmcgill298 thanks for looking into this PR. I never learned to rebase without screwing the log :(
I'll push the other one soon.

Copy link
Contributor

@jmcgill298 jmcgill298 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same as #809

@jpobeda
Copy link
Contributor Author

jpobeda commented Oct 26, 2020

@jmcgill298 I believe they should be fine now.

Copy link
Contributor

@jmcgill298 jmcgill298 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like there is still something a little off.

@jmcgill298 jmcgill298 merged commit 02ce807 into networktocode:master Oct 26, 2020
guillaume-mbali pushed a commit to unyc-io/ntc-templates that referenced this pull request Apr 12, 2023
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants