Fix#784 new: cisco asa show running all cryprom map #840
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
December 6, 2020 15:07
… remove unused IKE value
diepes
requested review from
FragmentedPacket,
itdependsnetworks,
jmcgill298 and
jvanderaa
as code owners
added 2 commits
December 6, 2020 18:13
to parse new test cisco_asa_show_running-config_crypto_map2.raw still broken template, return 2 out of 7 entries.
jmcgill298
requested changes
Dec 9, 2020
tests/cisco_asa/show_running-config_crypto_map/cisco_asa_show_running-config_crypto_map2.yml
Show resolved
Hide resolved
…tfsm use continue to capture new block on match of first line.
added 3 commits
December 20, 2020 12:04
…_show_running_cryprom_map
Value TRANSFORM capture multiple words
match multiword for IKEv1_TRANSFORM_SET
diepes
commented
Dec 20, 2020
There was a problem hiding this comment.
We need to look into the overwriting of entries per
tests/cisco_asa/show_running-config_crypto_map/cisco_asa_show_running-config_crypto_map2.raw
I had a look, the raw file has 6 map entries, and two lines we ignore.
crypto map WAN1_CMAP 65535 ipsec-isakmp dynamic SYSTEM_DEFAULT_CRYPTO_MAP
crypto map WAN1_CMAP interface WAN
the file tests/cisco_asa/show_running-config_crypto_map/cisco_asa_show_running-config_crypto_map2.yml contains 6 blocks.
I was not able to find overwritten entries.
Did fix a issue where the Values TRANSFORM was only capturing single word.
What line in tests/cisco_asa/show_running-config_crypto_map/cisco_asa_show_running-config_crypto_map2.yml look like they are over written ? Then i will try to track it down.
tests/cisco_asa/show_running-config_crypto_map/cisco_asa_show_running-config_crypto_map2.yml
Show resolved
Hide resolved
…_show_running_cryprom_map
|
Why is this still tagged [change requested] ? |
jmcgill298
approved these changes
Mar 9, 2021
jvanderaa
pushed a commit
that referenced
this pull request
Nov 10, 2021
guillaume-mbali
pushed a commit
to unyc-io/ntc-templates
that referenced
this pull request
Apr 12, 2023
cppmonkey
pushed a commit
to cppmonkey/ntc-templates
that referenced
this pull request
Oct 25, 2023
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ISSUE TYPE
COMPONENT
cisco asa show running all cryprom map
SUMMARY
need the "show running all" to get enough info collect info.