Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Adding new templates for show (radius|tacacs) summary output #855

Merged

Conversation

mjbear
Copy link
Contributor

@mjbear mjbear commented Jan 6, 2021

ISSUE TYPE
  • New Template Pull Request
COMPONENT

cisco_wlc_ssh_show_radius_summary.textfsm, cisco_wlc_ssh, show radius summary
cisco_wlc_ssh_show_tacacs_summary.textfsm, cisco_wlc_ssh, show tacacs summary

SUMMARY

Add parsing of Cisco WLC RADIUS and TACACS summary output so servers' addressing, statuses, and other settings can be programmatically accessed.


@mjbear
Copy link
Contributor Author

mjbear commented Jan 30, 2021

Similar to another of my PRs, this one will need rebased as well as a few modifications to the template (filldown).
Once I hear back if there are any additional suggested changes ... I'm fine with making a single rebase (rather than several rebases for any other PRs your team commits). Thank you!

@mjbear mjbear force-pushed the cisco_wlc_auth_protocols branch from 6e327c2 to b287059 Compare January 31, 2021 21:48
@mjbear mjbear force-pushed the cisco_wlc_auth_protocols branch from b287059 to a028369 Compare February 2, 2021 23:51
Value Filldown MAC_DELIM_ACCT_MSG (\S+)
Value Filldown AUTHC_FRAMED_MTU (\d+)
Value Required INDEX (\d+)
Value AUTHC_SRV_ADDR (\S+)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you change AUTHC and AUTHZ in these templates to the full names? e.g. AUTHORIZATION and AUTHENTICATION. It took me a few minutes to realize what it was.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would make ACCT long as well ACCOUNTING.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Replaced abbreviations with entire word.

Value AUTHC_SRV_ADDR (\S+)
Value ACCT_SRV_ADDR (\S+)
Value TYPE (\S+)
Value SRV_PORT (\d+)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm on the fence, but thinking these may not need the SRV_ prefix.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removed SRV_ from several variables.

@FragmentedPacket FragmentedPacket added the changes_requested Waiting on user to address feedback label Feb 3, 2021
…ing with the full words;

removed SRV_ from several variables out of conciseness;
removed _STR from a variable name out of conciseness;
added state changes in several sections just in case the output should later be in a different order
@FragmentedPacket FragmentedPacket merged commit cd0130e into networktocode:master Feb 3, 2021
cppmonkey pushed a commit to cppmonkey/ntc-templates that referenced this pull request Oct 25, 2023
@mjbear mjbear deleted the cisco_wlc_auth_protocols branch June 22, 2024 20:36
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
changes_requested Waiting on user to address feedback
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants