-
Notifications
You must be signed in to change notification settings - Fork 745
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Adding new templates for show (radius|tacacs) summary output #855
Adding new templates for show (radius|tacacs) summary output #855
Conversation
Similar to another of my PRs, this one will need rebased as well as a few modifications to the template (filldown). |
6e327c2
to
b287059
Compare
…addresses in unique variables (since server lists could technically differ based on what is possible via CLI configuration)
…ses in unique variables
b287059
to
a028369
Compare
Value Filldown MAC_DELIM_ACCT_MSG (\S+) | ||
Value Filldown AUTHC_FRAMED_MTU (\d+) | ||
Value Required INDEX (\d+) | ||
Value AUTHC_SRV_ADDR (\S+) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you change AUTHC
and AUTHZ
in these templates to the full names? e.g. AUTHORIZATION
and AUTHENTICATION
. It took me a few minutes to realize what it was.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would make ACCT
long as well ACCOUNTING
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Replaced abbreviations with entire word.
Value AUTHC_SRV_ADDR (\S+) | ||
Value ACCT_SRV_ADDR (\S+) | ||
Value TYPE (\S+) | ||
Value SRV_PORT (\d+) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm on the fence, but thinking these may not need the SRV_
prefix.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Removed SRV_ from several variables.
…ing with the full words; removed SRV_ from several variables out of conciseness; removed _STR from a variable name out of conciseness; added state changes in several sections just in case the output should later be in a different order
ISSUE TYPE
COMPONENT
cisco_wlc_ssh_show_radius_summary.textfsm, cisco_wlc_ssh, show radius summary
cisco_wlc_ssh_show_tacacs_summary.textfsm, cisco_wlc_ssh, show tacacs summary
SUMMARY
Add parsing of Cisco WLC RADIUS and TACACS summary output so servers' addressing, statuses, and other settings can be programmatically accessed.