Chloe task17 #13
Merged
Chloe task17 #13
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…Modified backend declineConvAreaInvite to take in a TeleportInviteSingular type instead and modified tests accordingly. Added back in some of the TownController clicked method tests that for some reason had been removed
chloe684
commented
Nov 6, 2022
dylanmarin
approved these changes
Nov 6, 2022
taylor-stevens
added
documentation
jafedor
reviewed
Nov 7, 2022
typo Co-authored-by: Jessica Fedor <71146773+jafedor@users.noreply.github.com>
…ject-group-308 into chloe-task17
taylor-stevens
approved these changes
Nov 7, 2022
jafedor
approved these changes
Nov 7, 2022
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added two methods in TownController that emit events to the townService + associated tests in TownController.tests:
Added two new events in CoveyTownSocket (which the two methods above emit).
Added two new listeners in Town that catch these two new events & call acceptConversationAreaInvite and declineConversationAreaInvite respectively + associated tests in Town.tests.
Also did some cleanup: