Skip to content
This repository has been archived by the owner on Aug 3, 2023. It is now read-only.

Update babel-preset-minify dependency #2

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

nemophrost
Copy link

Some great fixes and improvements have made it into babel-preset-minify and neutrino could benefit greatly from them.

Some great fixes and improvements have made it into babel-preset-minify and neutrino could benefit greatly from them.
@nemophrost
Copy link
Author

Any word on this? Right now you can't set any minify plugin options for plugins disabled by default.

Copy link
Member

@eliperelman eliperelman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems pretty innocuous, thoughts @edmorley?

@edmorley
Copy link
Member

edmorley commented Jun 26, 2018

There are a few more changes than this upstream:
master...webpack-contrib:master

Also worth noting that upstream is still on 0.3.0, whereas this PR updates to 0.4.0 which has even more breaking changes:
https://github.com/babel/minify/blob/master/CHANGELOG.md

Neutrino 9 stops using this plugin, so any changes here would only be useful for Neutrino 8, where breaking changes are not possible (with the caveat that I haven't looked at how severe the breaking changes are; they might not affect us / might still be worth it if the minification bug fixes are important enough).

# for free to subscribe to this conversation on GitHub. Already have an account? #.
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants