Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

feat: LIDO-68. Add query for validators signing infos and unbonding delegations query #122

Merged
merged 17 commits into from
Feb 22, 2024

Conversation

albertandrejev
Copy link
Member

@albertandrejev albertandrejev commented Nov 23, 2023

Add support for the signing info queries.

Side changes:

fix make compile caching
bump rust-optimizer from v0.14.0 to v0.15.0
bump Rust from v1.71.0 to v1.73.0
fix entry points in ictx contract
improve doc comments in ictx contract
fix ictx integration test
add make doc target
fix make doc warnings

Related PRs:

https://hadronlabs.atlassian.net/browse/LIDO-68

Test run

@albertandrejev albertandrejev changed the title Add query for validators signing infos feat: LIDO-68. Add query for validators signing infos Nov 23, 2023
Copy link
Collaborator

@pr0n00gler pr0n00gler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Integration tests?

Copy link
Collaborator

@pr0n00gler pr0n00gler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please fix clippy issues and unit tests

@albertandrejev
Copy link
Member Author

Integration tests?

partially, waiting for neutron-dev-contracts, and integration tests to be stabilized with main branch

@albertandrejev albertandrejev changed the base branch from main to sdk/47 December 7, 2023 15:07
@albertandrejev albertandrejev marked this pull request as ready for review December 12, 2023 10:21
ratik
ratik previously approved these changes Dec 20, 2023
@albertandrejev albertandrejev force-pushed the feat/LIDO-68-query-siginig-info branch from 0312d1e to f6e00d1 Compare December 20, 2023 17:35
@albertandrejev albertandrejev changed the title feat: LIDO-68. Add query for validators signing infos feat: LIDO-68. Add query for validators signing infos and unbonding delegations query Dec 22, 2023
@albertandrejev albertandrejev changed the base branch from sdk/47 to main January 9, 2024 11:17
@albertandrejev albertandrejev dismissed ratik’s stale review January 9, 2024 11:17

The base branch was changed.

@albertandrejev
Copy link
Member Author

pr0n00gler
pr0n00gler previously approved these changes Jan 14, 2024
albertandrejev and others added 11 commits February 22, 2024 12:55
Side changes:
- fix `make compile` caching
- bump rust-optimizer from v0.14.0 to v0.15.0
- bump Rust from v1.71.0 to v1.73.0
- fix entry points in ictx contract
- improve doc comments in ictx contract
- fix ictx integration test
- add `make doc` target
- fix `make doc` warnings
…ies.rs

Co-authored-by: Mike Mozhaev <programmer10110@gmail.com>
Co-authored-by: Mike Mozhaev <programmer10110@gmail.com>
Co-authored-by: Mike Mozhaev <programmer10110@gmail.com>
@albertandrejev albertandrejev force-pushed the feat/LIDO-68-query-siginig-info branch from e753df9 to 20d91c0 Compare February 22, 2024 10:56
@pr0n00gler pr0n00gler merged commit 6842031 into main Feb 22, 2024
6 checks passed
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants