Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Add query for proposal voters #129

Merged
merged 2 commits into from
Apr 11, 2024
Merged

Add query for proposal voters #129

merged 2 commits into from
Apr 11, 2024

Conversation

albertandrejev
Copy link
Member

@albertandrejev albertandrejev commented Feb 7, 2024

This PR will add support for queries of the proposal voting process. It will let to query votes per voter and per proposal.

Related PRs:

  1. Dev Contracts
  2. Integration Tests

@albertandrejev albertandrejev changed the base branch from main to feat/LIDO-68-query-siginig-info February 20, 2024 08:36
@albertandrejev albertandrejev marked this pull request as ready for review February 22, 2024 09:08
@albertandrejev albertandrejev requested review from sotnikov-s, pr0n00gler and foxpy and removed request for sotnikov-s and pr0n00gler February 22, 2024 09:09
@albertandrejev albertandrejev force-pushed the feat/LIDO-68-query-siginig-info branch from e753df9 to 20d91c0 Compare February 22, 2024 10:56
@@ -36,6 +36,11 @@ pub fn query_kv_result<T: KVReconstruct>(
) -> NeutronResult<T> {
let registered_query_result = get_raw_interchain_query_result(deps, query_id)?;

deps.api.debug(&format!(
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

let's remove debug from package itself

@albertandrejev albertandrejev requested a review from ratik February 22, 2024 11:44
ratik
ratik previously approved these changes Feb 22, 2024
@albertandrejev albertandrejev changed the base branch from feat/LIDO-68-query-siginig-info to main February 22, 2024 13:06
@albertandrejev albertandrejev dismissed ratik’s stale review February 22, 2024 13:06

The base branch was changed.

Copy link
Collaborator

@pr0n00gler pr0n00gler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please attach purpose of this PR and all the related PRs.

It will simplify a review process

ratik
ratik previously approved these changes Feb 22, 2024
ratik
ratik previously approved these changes Mar 14, 2024
Copy link
Contributor

@sotnikov-s sotnikov-s left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please attach a successful testrun link

@albertandrejev
Copy link
Member Author

@pr0n00gler pr0n00gler merged commit 93d7999 into main Apr 11, 2024
12 checks passed
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants