Remove usage of deprecated data field in Neutron SDK ICTX helper for SDK 0.47 chains & update SDK 0.45 helper to backw compat NTRN-223
#134
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
quasisamurai
force-pushed
the
feat/deprecated-data-field-ictx
branch
from
dcc1872 to
8483e61
Compare
quasisamurai
changed the title
data field in Neutron SDK ICTX helper for SDK 0.47 chains & update SDK 0.45 helper to backw compatdata field in Neutron SDK ICTX helper for SDK 0.47 chains & update SDK 0.45 helper to backw compat NTRN-223
quasisamurai
force-pushed
the
feat/deprecated-data-field-ictx
branch
from
8483e61 to
b696b8e
Compare
pr0n00gler
reviewed
Feb 29, 2024
This was referenced Mar 6, 2024
sotnikov-s
reviewed
Mar 12, 2024
Comment on lines
17
to
34
| Ok(msg) => { | ||
| if !msg.msg_responses.is_empty() { | ||
| msg.msg_responses | ||
| .into_iter() | ||
| .map(|any_msg| { | ||
| Ok(MsgData { | ||
| msg_type: any_msg.type_url, | ||
| data: any_msg.value, | ||
| }) | ||
| }) | ||
| .collect::<StdResult<Vec<MsgData>>>() | ||
| } else { | ||
| // Field `.data` is deprecated since cosmos-sdk v047. | ||
| // But for backwards compatibility we still allow that. Given function can be used w both v045 & v047 | ||
| #[allow(deprecated)] | ||
| Ok(msg.data) | ||
| } | ||
| } |
There was a problem hiding this comment.
we decided to remove the branch for v047 from here, didn't we?
| use cosmwasm_std::{Binary, StdError, StdResult}; | ||
|
|
||
| /// Decodes acknowledgement into `Vec<MsgData>` structure | ||
| /// We consider this method as deprecated. Use v047 instead. |
There was a problem hiding this comment.
do we still need this comment line?
pr0n00gler
approved these changes
Mar 13, 2024
sotnikov-s
approved these changes
Mar 13, 2024
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TASK
related prs:
neutron-org/neutron-dev-contracts#43
neutron-org/neutron-integration-tests#271