Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Feat/add price to limit order #472

Merged
merged 25 commits into from
May 31, 2024
Merged

Feat/add price to limit order #472

merged 25 commits into from
May 31, 2024

Conversation

jcompagni10
Copy link
Contributor

@jcompagni10 jcompagni10 commented Mar 27, 2024 •
edited
Loading

Allow limit orders to be placed by specifying a price instead of a tick
Tests still breaking because of pending rounding changes.

neutron-sdk changes: neutron-org/neutron-sdk#143
integration-test changes: neutron-org/neutron-integration-tests#294

@jcompagni10 jcompagni10 force-pushed the feat/add_price_to_lo branch from c914180 to 75f62ad Compare April 12, 2024 22:03
@jcompagni10 jcompagni10 marked this pull request as ready for review April 12, 2024 22:03
@pr0n00gler pr0n00gler changed the base branch from main to feat/sdk-50 April 25, 2024 15:54
pr0n00gler
pr0n00gler requested changes Apr 25, 2024
View reviewed changes
x/dex/types/price.go Show resolved Hide resolved
x/dex/keeper/msg_server.go Outdated Show resolved Hide resolved
proto/neutron/dex/tx.proto Outdated Show resolved Hide resolved
@pr0n00gler
Copy link
Collaborator

there are a couple of conflicts 🙈

pr0n00gler
pr0n00gler requested changes Apr 27, 2024
View reviewed changes
proto/neutron/dex/tx.proto Outdated Show resolved Hide resolved
swelf19
swelf19 previously approved these changes May 8, 2024
View reviewed changes
x/dex/utils/math.go Outdated Show resolved Hide resolved
x/dex/types/price.go Outdated Show resolved Hide resolved
x/dex/types/price_test.go Show resolved Hide resolved
x/dex/client/cli/tx_place_limit_order.go Outdated Show resolved Hide resolved
x/dex/types/message_place_limit_order_test.go Outdated Show resolved Hide resolved
x/dex/types/message_place_limit_order_test.go Outdated Show resolved Hide resolved
x/dex/types/message_place_limit_order_test.go Outdated Show resolved Hide resolved
wasmbinding/bindings/msg.go Outdated Show resolved Hide resolved
@swelf19 swelf19 dismissed their stale review May 8, 2024 17:49

set approve by mistake

@jcompagni10 jcompagni10 mentioned this pull request May 8, 2024
Merged
@jcompagni10 jcompagni10 force-pushed the feat/add_price_to_lo branch from c0bcd99 to a0f03c2 Compare May 8, 2024 22:41
This was referenced May 8, 2024
Merged
Merged
swelf19
swelf19 reviewed May 15, 2024
View reviewed changes
x/dex/utils/math.go Outdated Show resolved Hide resolved
x/dex/utils/math_test.go Outdated Show resolved Hide resolved
sotnikov-s
sotnikov-s reviewed May 22, 2024
View reviewed changes
wasmbinding/message_plugin.go Outdated Show resolved Hide resolved
x/dex/keeper/msg_server.go Outdated Show resolved Hide resolved
x/dex/types/errors.go Outdated Show resolved Hide resolved
x/dex/types/price.go Outdated Show resolved Hide resolved
x/dex/types/price.go Show resolved Hide resolved
swelf19
swelf19 reviewed May 24, 2024
View reviewed changes
x/dex/utils/math_test.go Outdated Show resolved Hide resolved
sotnikov-s
sotnikov-s approved these changes May 24, 2024
View reviewed changes
Copy link
Contributor

@sotnikov-s sotnikov-s left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. please resolve conflicts and it seems to be good to go

@jcompagni10
Copy link
Contributor Author

jcompagni10 commented May 24, 2024 •
edited
Loading

https://github.com/neutron-org/neutron-tests/actions/runs/9280203744

@pr0n00gler
Copy link
Collaborator

pr0n00gler commented May 27, 2024 •
edited
Loading

Integration tests are not passing due to some linter error in dev-contracts, please fix them

sotnikov-s
sotnikov-s approved these changes May 30, 2024
View reviewed changes
Copy link
Contributor

@sotnikov-s sotnikov-s left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please attach a successful test run

@jcompagni10
Copy link
Contributor Author

please attach a successful test run

https://github.com/neutron-org/neutron-tests/actions/runs/9280203744/attempts/4

@jcompagni10
Copy link
Contributor Author

https://github.com/neutron-org/neutron-tests/actions/runs/9280203744

@pr0n00gler pr0n00gler merged commit 4609520 into feat/sdk-50 May 31, 2024
9 checks passed
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@pr0n00gler pr0n00gler pr0n00gler approved these changes

@sotnikov-s sotnikov-s sotnikov-s approved these changes

@swelf19 swelf19 swelf19 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@jcompagni10 @pr0n00gler @sotnikov-s @swelf19