Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Ewm6383 truncate edges staging #434

Merged
merged 2 commits into from
Aug 5, 2024

Conversation

dlcaballero16
Copy link
Collaborator

This work is covered by PR 432: #432

See the link for more info

Updated high dSpacing crop value

Added check to make sure dMax is greater than dMin

Fixed unit tests

Added test for coverage
Copy link

codecov bot commented Aug 5, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.41%. Comparing base (09826f8) to head (5364aa5).
Report is 14 commits behind head on staging.

Additional details and impacted files
@@             Coverage Diff             @@
##           staging     #434      +/-   ##
===========================================
+ Coverage    95.39%   95.41%   +0.02%     
===========================================
  Files           60       60              
  Lines         3822     3840      +18     
===========================================
+ Hits          3646     3664      +18     
  Misses         176      176              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@ekapadi ekapadi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review same as for "next" version (at PR #432).
I ran all tests as described, including the unit-test suite.
Everything looks good.

@dlcaballero16 dlcaballero16 merged commit e903c1b into staging Aug 5, 2024
7 checks passed
@dlcaballero16 dlcaballero16 deleted the ewm6383-truncate-edges-staging branch August 5, 2024 18:17
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants