Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Add GitHub actions for unit tests #15

Merged
merged 4 commits into from
Jun 10, 2024
Merged

Add GitHub actions for unit tests #15

merged 4 commits into from
Jun 10, 2024

Conversation

backmari
Copy link
Collaborator

@backmari backmari commented Jun 10, 2024

Short description of the changes:

Add GitHub actions to run unit tests on pull requests.

Check list for the pull request

  • I have read the [CONTRIBUTING]
  • I have read the [CODE_OF_CONDUCT]
  • I have added tests for my changes
  • I have updated the documentation accordingly

Check list for the reviewer

  • I have read the [CONTRIBUTING]
  • I have verified the proposed changes
  • best software practices
    • all internal functions have an underbar, as is python standard
    • clearly named variables (better to be verbose in variable names)
    • code comments explaining the intent of code blocks
  • All the tests are passing
  • The documentation is up to date
  • code comments added when explaining intent

Manual test for the reviewer

References

@KedoKudo KedoKudo self-requested a review June 10, 2024 13:34
Copy link
Member

@KedoKudo KedoKudo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look good 👍

@KedoKudo KedoKudo merged commit 8f377b2 into main Jun 10, 2024
1 check passed
@KedoKudo KedoKudo deleted the ci_unittest branch June 10, 2024 13:36
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants