Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Update docker base image and move to Python 3.6 + Django 2.0 #9

Merged
merged 2 commits into from
Apr 30, 2024

Conversation

backmari
Copy link
Collaborator

@backmari backmari commented Apr 26, 2024

Short description of the changes:

First step in migrating Live Data Server to newer versions of Python and Django.

Information about changes between Django 1.9 and 2.0:
https://docs.djangoproject.com/en/dev/releases/1.10/#deprecated-features-1-10
https://docs.djangoproject.com/en/dev/releases/2.0/#backwards-incompatible-changes-in-2-0

Check list for the pull request

  • I have read the [CONTRIBUTING]
  • I have read the [CODE_OF_CONDUCT]
  • I have added tests for my changes
  • I have updated the documentation accordingly

Check list for the reviewer

  • I have read the [CONTRIBUTING]
  • I have verified the proposed changes
  • best software practices
    • all internal functions have an underbar, as is python standard
    • clearly named variables (better to be verbose in variable names)
    • code comments explaining the intent of code blocks
  • All the tests are passing
  • The documentation is up to date
  • code comments added when explaining intent

Manual test for the reviewer

Define environment variables (name, user, password can be set to anything):

export DATABASE_NAME=***
export DATABASE_USER=***
export DATABASE_PASS=***
export DATABASE_HOST=db  # name of the db docker service
export DATABASE_PORT=5432
export LIVE_PLOT_SECRET_KEY=""

Start the containers:

make local/docker/up

and when the containers are up run the unit test:

DJANGO_SUPERUSER_USERNAME=<same as DATABASE_USER> DJANGO_SUPERUSER_PASSWORD=<same as DATABASE_PASS> pytest tests

References

Story 4767: [LiveDataServer] Deploy containerized Live Data Server and test with WebMon test environment

@peterfpeterson
Copy link
Member

The way that our conda deploy is setup uses conda_bootstrap.sh

@backmari backmari force-pushed the python3.6_django2.0 branch from 1c7ac23 to f26832b Compare April 29, 2024 18:54
@backmari backmari changed the title Python3.6 django2.0 Update docker base image and move to Python 3.6 + Django 2.0 Apr 29, 2024
@backmari backmari force-pushed the python3.6_django2.0 branch from f26832b to 9947100 Compare April 30, 2024 12:52
@backmari backmari force-pushed the python3.6_django2.0 branch from 9947100 to 290c27f Compare April 30, 2024 17:28
Copy link
Member

@jmborr jmborr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks 👌

@backmari backmari merged commit b526af5 into main Apr 30, 2024
@rosswhitfield rosswhitfield deleted the python3.6_django2.0 branch May 28, 2024 04:24
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants