initElem: setHover only if attrsHover set #176
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
neveldo
added a commit
that referenced
this pull request
Dec 22, 2015
initElem: setHover only if attrsHover set
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this PR, I propose:
setEventHandlersandsetHover: they can be called once. The check totextElemto undefined is also done in their respective function.setHover()(which effectively attach mouseIn/Out events handler to the element) only if attrsHover is set for the area or for the textElem. With this way, if a user has overrided the defaultOptions attrsHover with an empty object, we don't assign any useless events.