Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Add a scan function to the gas deposit locator #2997

Open
wants to merge 8 commits into
base: master
Choose a base branch
from

Conversation

whatston3
Copy link
Contributor

@whatston3 whatston3 commented Feb 28, 2025

About the PR

Renames the gas deposit locater to the gas deposit scanner. Adds a really simple, gas analyzer-like interface to see the approximate composition of a gas deposit. Used like the gas analyzer, hold it in-hand, click the deposit on the ground to view it.

Gas mining drills now give an estimate of the amount of gas remaining in a deposit to the nearest kilomole.

Minor reorganization: moves the bidirectional pump UI to a BUI folder along with the GasDepositScanner and GasSalePoint BUI.

Why / Balance

Gas mining quality of life.

How to test

  1. Spawn gas deposit.
  2. Scan with gas deposit scanner. It should light up (showing moving lines) and display the rough composition of the deposit.
  3. Close the window. The gas deposit scanner should turn off.
  4. Use the gas deposit scanner in-hand, it should start beeping and swap to the existing "bubbles" screen graphic.
  5. Scan the deposit with the gas deposit scanner. It should switch back to the lines graphic but stop beeping.
  6. Use the gas deposit scanner in-hand, it should stop beeping but keep the lines graphic present.
  7. Spawn a gas mining drill, anchor it to the deposit.
  8. Examine the drill, it should report the gas amount to the nearest kilomol.

Media

The composition of a very large air deposit, showing each composition amount from Enormous to Trace.
image

Requirements

Breaking changes

Changelog

🆑

  • tweak: The gas deposit locator has been renamed to the gas deposit scanner.
  • add: The gas deposit scanner can now be used on gas deposits to show their composition.

Copy link
Contributor

github-actions bot commented Feb 28, 2025

RSI Diff Bot; head commit f17c17d merging into 20cbb5d
This PR makes changes to 1 or more RSIs. Here is a summary of all changes:

Resources/Textures/_NF/Objects/Specific/Atmospherics/locator.rsi

State Old New Status
data Added

Edit: diff updated after f17c17d

@dustylens
Copy link
Contributor

Outside the scope of this PR but what do you think of a shuttle mounted scanner that could provide similar functionality in broad terms and provide the mechanisms needed to spawn gas deposits? I'm thinking for the purposes of the Ambition/other future shuttles that may not benefit from having a player present in the locations that may be most beneficial for approaching and investigating an asteroid.

@whatston3
Copy link
Contributor Author

Outside the scope of this PR but what do you think of a shuttle mounted scanner that could provide similar functionality in broad terms and provide the mechanisms needed to spawn gas deposits? I'm thinking for the purposes of the Ambition/other future shuttles that may not benefit from having a player present in the locations that may be most beneficial for approaching and investigating an asteroid.

Possible. It's a little bit of a pain because you'll need to generate the number of entities to place ahead of time, then pull from that value when making the floor plan. Outside of world generation though, you can just point to the asteroid with that non-zero value within a range from, say 20-100m, which should be fine if you're pointing to some arbitrary point on the asteroid.

@dustylens
Copy link
Contributor

A general remote scanner to say "yes, this one is probably worth going in manually to check things out" vs "no, nothing seems to be here" scanner. Not enough to let you sit and review an entire sector but maybe enough to be a QoL issue if it ever comes up.

Not sure if it's a matter for concern for Ambtition pilots. I'm not sure why anyone flies the Ambition, having none myself.

@dvir001 dvir001 self-requested a review February 28, 2025 13:34
@dvir001
Copy link
Contributor

dvir001 commented Feb 28, 2025

Holy BUI this is cool, ill give it a test soon

# for free to join this conversation on GitHub. Already have an account? # to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants