-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Update documentation for OTel -> AWS infra relationships #20025
base: develop
Are you sure you want to change the base?
Update documentation for OTel -> AWS infra relationships #20025
Conversation
Hi @alanwest 👋 Thanks for your pull request! Your PR is in a queue, and a writer will take a look soon. We generally publish small edits within one business day, and larger edits within three days. We will automatically generate a preview of your request, and will comment with a link when the preview is ready (usually 10 to 20 minutes). |
✅ Deploy Preview for docs-website-netlify ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Couple of comments, but possibly things we can improve later.
src/content/docs/opentelemetry/best-practices/opentelemetry-best-practices-resources.mdx
Outdated
Show resolved
Hide resolved
<thead> | ||
<tr> | ||
<th> | ||
Supported by instrumentation |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For this column, given that not all instrumentations in all languages will contain the data required for relationships, do you think its worth it to discuss what the specific requirements are of instrumentation?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I was trying to avoid that at least to begin with. In general, I think the rules are decent and will cover most of the instrumentation that exists out there. That said, if we discover customers are struggling then we can figure out how best to elaborate.
@Sanjalee-NewRelic @vinaykonatala @AravindKumar8520