Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Update documentation for OTel -> AWS infra relationships #20025

Open
wants to merge 4 commits into
base: develop
Choose a base branch
from

Conversation

alanwest
Copy link
Member

@alanwest alanwest requested a review from a team as a code owner February 21, 2025 00:47
Copy link

Hi @alanwest 👋

Thanks for your pull request! Your PR is in a queue, and a writer will take a look soon. We generally publish small edits within one business day, and larger edits within three days.

We will automatically generate a preview of your request, and will comment with a link when the preview is ready (usually 10 to 20 minutes).

Copy link

netlify bot commented Feb 21, 2025

Deploy Preview for docs-website-netlify ready!

Name Link
🔨 Latest commit ff98496
🔍 Latest deploy log https://app.netlify.com/sites/docs-website-netlify/deploys/67b91431c67f7f0008cc8fdb
😎 Deploy Preview https://deploy-preview-20025--docs-website-netlify.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

jack-berg
jack-berg previously approved these changes Feb 21, 2025
Copy link
Contributor

@jack-berg jack-berg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Couple of comments, but possibly things we can improve later.

<thead>
<tr>
<th>
Supported by instrumentation
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For this column, given that not all instrumentations in all languages will contain the data required for relationships, do you think its worth it to discuss what the specific requirements are of instrumentation?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was trying to avoid that at least to begin with. In general, I think the rules are decent and will cover most of the instrumentation that exists out there. That said, if we discover customers are struggling then we can figure out how best to elaborate.

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants