nrgrpc integration is now reporting non-errors as errors in the UI

[odannyc]

Description

The latest version of the newrelic grpc integration package is reporting all grpc codes as errors. I believe the issue is here:

https://github.com/newrelic/go-agent/blob/master/v3/integrations/nrgrpc/nrgrpc_server.go#L85-L87

I think we should do filtering on grpc codes that are actual errors. Here is an example of what filtering another library does:

https://github.com/grpc-ecosystem/go-grpc-middleware/blob/master/logging/zap/options.go#L104-L144

Steps to Reproduce

• return a NotFound error code from the grpc server

Expected Behavior

• Does not show up in newrelic as an "error"

NR Diag results

Your Environment

Reproduction case

Additional context

[nr-swilloughby]

Thanks for raising this issue. We're looking into the best way to provide the greater granularity you are requesting so that instead of reporting any non-OK status as an error, we can selectively report them as errors, warnings, info, etc.

[RichVanderwal]

Releasing this very soon!

[RichVanderwal]

Hi @odannyc , we released the 3.14.0 version of the Go Agent, which has a configurable error handler for gRPC.

We'd love it if you could give it a spin! Here are the docs for this new error handling.