-
Notifications
You must be signed in to change notification settings - Fork 301
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Custom Events Limiter #524
Conversation
Mirac Kara seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account. You have signed the CLA already but the status is still pending? Let us recheck it. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This seems to be causing a number of the legacy tests to fail, which it should not effect. I think we should get to the bottom of why that is happening before we merge anything.
I noticed that some of your changes altered internal, rather than v3/internal. I suspect that a lot of your trouble is coming from that change.
Good catch! |
Legacy tests are now good. Looks like some more of the v3 tests are failing however. Thanks for the comment! |
Thanks for looking at how the other agents are configured when you were naming this option! |
da36b6e
to
b328ef4
Compare
Looks a lot better. Once it passes tests, this is ready to squash and merge |
Description
Added configuration option for limiting the amount of samples stored in a custom insights event.
Usage
When creating a new application, use the following function to limit sample sizes