Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

fix(logging): don't pollute logs with event when truncating event #2004

Merged
merged 1 commit into from
Jan 22, 2025
Merged

fix(logging): don't pollute logs with event when truncating event #2004

merged 1 commit into from
Jan 22, 2025

Conversation

rajrohanyadav
Copy link
Contributor

Closes #866

@rajrohanyadav rajrohanyadav requested a review from a team as a code owner January 21, 2025 05:53
@rajrohanyadav rajrohanyadav marked this pull request as draft January 21, 2025 06:22
@rajrohanyadav rajrohanyadav force-pushed the fix-issue-866-truncated-log branch from 9725cd2 to ea7c1f4 Compare January 21, 2025 06:47
@rajrohanyadav rajrohanyadav changed the title fix(logging): don't pollute logs with actual event when truncating event fix(logging): don't pollute logs with event when truncating event Jan 21, 2025
@coveralls
Copy link

Pull Request Test Coverage Report for Build 12881582903

Details

  • 7 of 7 (100.0%) changed or added relevant lines in 1 file are covered.
  • 8 unchanged lines in 3 files lost coverage.
  • Overall coverage decreased (-0.01%) to 57.328%
Files with Coverage Reduction New Missed Lines %
pkg/metrics/sampler/sampler_routine.go 2 95.35%
internal/integrations/v4/testhelp/testemit/testemit.go 2 90.63%
internal/agent/agent.go 4 65.51%
Totals Coverage Status
Change from base Build 12880763854: -0.01%
Covered Lines: 15368
Relevant Lines: 26807
💛 - Coveralls

@rajrohanyadav rajrohanyadav marked this pull request as ready for review January 21, 2025 06:59
rubenruizdegauna
rubenruizdegauna approved these changes Jan 22, 2025
View reviewed changes
Copy link
Contributor

@rubenruizdegauna rubenruizdegauna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks for taking care of it :)

@rajrohanyadav rajrohanyadav merged commit 97527f8 into master Jan 22, 2025
24 checks passed
@rajrohanyadav rajrohanyadav deleted the fix-issue-866-truncated-log branch January 22, 2025 16:00
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@rubenruizdegauna rubenruizdegauna rubenruizdegauna approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
3 participants
@rajrohanyadav @coveralls @rubenruizdegauna