Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Pekko support #1811

Merged
merged 4 commits into from
Mar 26, 2024
Merged

Pekko support #1811

merged 4 commits into from
Mar 26, 2024

Conversation

kanderson250
Copy link
Contributor

@kanderson250 kanderson250 commented Mar 21, 2024

Resolves #1692

This PR adds support for Apache Pekko.

Pekko is a fork of Akka 2.6. As such, the instrumentation is a direct lift of our existing Akka instrumentation.

Corresponding AITs have also been added.

Copy link
Contributor

@jtduffy jtduffy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Only thing I see are the copyright messages are all 2020 (from the previous module), bit no idea if that's an issue for NR or not.

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 70.85%. Comparing base (267afe2) to head (b2bf5a2).
Report is 29 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##               main    #1811    +/-   ##
==========================================
  Coverage     70.84%   70.85%            
- Complexity     9951     9971    +20     
==========================================
  Files           827      829     +2     
  Lines         39880    39984   +104     
  Branches       6043     6058    +15     
==========================================
+ Hits          28254    28330    +76     
- Misses         8900     8925    +25     
- Partials       2726     2729     +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@kanderson250 kanderson250 merged commit 0e7ec17 into main Mar 26, 2024
106 checks passed
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

Add support for Apache Pekko
3 participants