Add HTTP/2 Support For Netty 4.1.16.Final + #1815
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #1789
Adds a new
netty-4.1.16instrumentation module and caps the range of versions supported by the oldnetty-4.0.8module.In addition to supporting HTTP/1, this new instrumentation module adds support for HTTP/2 starting with Netty version
io.netty:netty-all:4.1.16.Finalup to the latest4.1.xversions (at the time this instrumentation was added the most recent version of Netty wasio.netty:netty-all:4.1.107.Final).Note: There are a small number of old Netty versions (4.1.0.Beta4 - 4.1.15.Final) that technically provide HTTP/2 functionality but will be instrumented by the older
netty-4.0.8module and thus won't have HTTP/2 support from us. This decision was made because those old Netty versions, which were all published from 2015-2017, have an extremely unstable HTTP/2 API which was frequently being refactored, making it difficult to instrument. Chances are extremely low that anyone would actually be using HTTP/2 with any of these early Netty versions.AIT changes in the following PR will resolve the test failures: https://github.com/newrelic/java-agent-integration-tests/pull/255