Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Resolve Kinesis verifier #2123

Merged
merged 2 commits into from
Nov 5, 2024
Merged

Resolve Kinesis verifier #2123

merged 2 commits into from
Nov 5, 2024

Conversation

obenkenobi
Copy link
Contributor

@obenkenobi obenkenobi commented Nov 4, 2024

Overview

Resolve verifier failure introduced in from adding arn processing for kinesis.

Related Github Issue

#2071

Copy link
Contributor

@jasonjkeller jasonjkeller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

Did you manually run the verifier against both of these modules?

@codecov-commenter
Copy link

codecov-commenter commented Nov 4, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 70.69%. Comparing base (2d209e0) to head (0ff2275).
Report is 1 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff              @@
##               main    #2123      +/-   ##
============================================
- Coverage     70.70%   70.69%   -0.02%     
+ Complexity     9982     9980       -2     
============================================
  Files           841      841              
  Lines         40289    40289              
  Branches       6107     6107              
============================================
- Hits          28487    28481       -6     
- Misses         9055     9063       +8     
+ Partials       2747     2745       -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@obenkenobi obenkenobi merged commit 1e56ef1 into main Nov 5, 2024
111 checks passed
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants