Jetty12 missing headers impl #2140
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
obenkenobi
force-pushed
the
jetty12-missing-headers-impl
branch
from
458fb2f to
be7450b
Compare
meiao
force-pushed
the
jetty12-missing-headers-impl
branch
from
be7450b to
46dfae5
Compare
meiao
approved these changes
Nov 12, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2140 +/- ##
============================================
- Coverage 70.69% 70.68% -0.02%
+ Complexity 9985 9982 -3
============================================
Files 841 841
Lines 40290 40290
Branches 6107 6107
============================================
- Hits 28485 28479 -6
- Misses 9062 9066 +4
- Partials 2743 2745 +2 ☔ View full report in Codecov by Sentry. |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Resolves an issue in the Jetty 12 instrumentation module where the JettyRequest class does not have the method implementation for
String getHeader(String name).Related Github Issue
#2139