Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Correct Apdex on transaction event if an error is present #2191

Merged
merged 1 commit into from
Jan 6, 2025

Conversation

jtduffy
Copy link
Contributor

@jtduffy jtduffy commented Jan 3, 2025

Overview

This fix will properly assign an apdex of Frustrating if an non-ignored and unexpected error is present on the transaction. This mirrors the behavior of the WebRequestDispatcher when reporting Apdex metrics on a transaction.

Related Github Issue

Resolves #2104

@codecov-commenter
Copy link

codecov-commenter commented Jan 3, 2025

Codecov Report

Attention: Patch coverage is 75.00000% with 1 line in your changes missing coverage. Please review.

Project coverage is 70.57%. Comparing base (0704419) to head (24dcc36).

Files with missing lines Patch % Lines
.../main/java/com/newrelic/agent/TransactionData.java 75.00% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##               main    #2191      +/-   ##
============================================
- Coverage     70.58%   70.57%   -0.01%     
- Complexity     9972     9973       +1     
============================================
  Files           842      842              
  Lines         40363    40367       +4     
  Branches       6116     6117       +1     
============================================
  Hits          28490    28490              
+ Misses         9099     9097       -2     
- Partials       2774     2780       +6     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jtduffy jtduffy merged commit 13ad7f1 into main Jan 6, 2025
114 checks passed
@jtduffy jtduffy deleted the txndata-apdex-fix branch January 6, 2025 16:03
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
3 participants