Skip to content

Commit

Permalink
fix: Updated messaging example instrumentation file (#304)
Browse files Browse the repository at this point in the history
Signed-off-by: mrickard <maurice@mauricerickard.com>
  • Loading branch information
mrickard authored Oct 30, 2024
1 parent e16933c commit 9415503
Show file tree
Hide file tree
Showing 2 changed files with 7 additions and 8 deletions.
13 changes: 6 additions & 7 deletions custom-instrumentation/instrument-messages/instrumentation.js
Original file line number Diff line number Diff line change
Expand Up @@ -85,14 +85,13 @@ function instrumentNiftyMessages(shim, messages, moduleName) {
shim.recordConsume(Client.prototype, 'getMessage', new shim.specs.MessageSpec({
destinationName: shim.FIRST,
callback: shim.LAST,
after({ args }) {
const [err, msg] = args
if (msg) {
after({ result, error }) {
if (result) {
console.log(
`[NEWRELIC] getMessage on queue ${msg.queueName} returned a message: '${msg.msg}'`
`[NEWRELIC] getMessage on queue ${result.queueName} returned a message: '${result.msg}'`
)
// misc key/value parameters can be recorded as a part of the trace segment
const params = { message: msg.msg, queueName: msg.queueName }
const params = { message: result.msg, queueName: result.queueName }

return {
parameters: params
Expand All @@ -101,7 +100,7 @@ function instrumentNiftyMessages(shim, messages, moduleName) {

console.log('[NEWRELIC] getMessage returned no message')
return {
parameters: { err }
parameters: { err: error }
}
}
}))
Expand Down Expand Up @@ -155,4 +154,4 @@ function instrumentNiftyMessages(shim, messages, moduleName) {
parameters: params
})
})
}
}
2 changes: 1 addition & 1 deletion custom-instrumentation/instrument-messages/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@
"license": "ISC",
"dependencies": {
"express": "^4.19.2",
"newrelic": "^12.0.0"
"newrelic": "^12.5.0"
},
"devDependencies": {
"@newrelic/eslint-config": "^0.2.0"
Expand Down

0 comments on commit 9415503

Please # to comment.