-
Notifications
You must be signed in to change notification settings - Fork 409
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
refactor: Updated shim classes to no longer construct specs. #2096
Conversation
3e8e4a2
to
88d2dff
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2096 +/- ##
==========================================
- Coverage 97.21% 97.20% -0.01%
==========================================
Files 251 251
Lines 42392 42317 -75
==========================================
- Hits 41210 41133 -77
- Misses 1182 1184 +2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me.
Description
I couldn't remove all the construction of specs in shim because at some point that are deriving existing specs to do something else.
Related Issues
Closes #2037