Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

refactor: Updated shim classes to no longer construct specs. #2096

Merged
merged 4 commits into from
Apr 2, 2024

Conversation

bizob2828
Copy link
Member

@bizob2828 bizob2828 commented Mar 22, 2024

Description

I couldn't remove all the construction of specs in shim because at some point that are deriving existing specs to do something else.

Related Issues

Closes #2037

@bizob2828 bizob2828 force-pushed the update-spec-construction branch from 3e8e4a2 to 88d2dff Compare March 22, 2024 15:30
Copy link

codecov bot commented Mar 22, 2024

Codecov Report

Attention: Patch coverage is 99.38272% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 97.20%. Comparing base (df2a0fd) to head (4801de0).

❗ Current head 4801de0 differs from pull request most recent head 6fc4584. Consider uploading reports for the commit 6fc4584 to get more accurate results

Files Patch % Lines
lib/instrumentation/mongodb/common.js 96.96% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2096      +/-   ##
==========================================
- Coverage   97.21%   97.20%   -0.01%     
==========================================
  Files         251      251              
  Lines       42392    42317      -75     
==========================================
- Hits        41210    41133      -77     
- Misses       1182     1184       +2     
Flag Coverage Δ
integration-tests-16.x 78.30% <35.13%> (+0.05%) ⬆️
integration-tests-18.x 78.27% <35.13%> (+0.03%) ⬆️
integration-tests-20.x 78.27% <35.13%> (+0.04%) ⬆️
unit-tests-16.x 90.44% <99.12%> (-0.16%) ⬇️
unit-tests-18.x 90.35% <99.12%> (-0.23%) ⬇️
unit-tests-20.x 90.35% <99.12%> (-0.23%) ⬇️
versioned-tests-16.x 74.48% <79.01%> (-0.05%) ⬇️
versioned-tests-18.x 75.60% <79.01%> (-0.05%) ⬇️
versioned-tests-20.x 75.60% <79.01%> (-0.05%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@bizob2828 bizob2828 marked this pull request as ready for review March 22, 2024 19:03
@bizob2828 bizob2828 changed the title refactor: updated shim classes to no longer construct specs. refactor: Updated shim classes to no longer construct specs. Mar 22, 2024
@mrickard mrickard self-assigned this Mar 22, 2024
mrickard
mrickard previously approved these changes Mar 22, 2024
jsumners-nr
jsumners-nr previously approved these changes Apr 1, 2024
Copy link
Contributor

@jsumners-nr jsumners-nr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

jsumners-nr
jsumners-nr previously approved these changes Apr 2, 2024
@bizob2828 bizob2828 merged commit 158c295 into newrelic:main Apr 2, 2024
23 checks passed
@bizob2828 bizob2828 deleted the update-spec-construction branch April 3, 2024 19:42
@github-actions github-actions bot mentioned this pull request Apr 9, 2024
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

Update shim classes to no longer construct specs
3 participants