Update links in CONTRIBUTING.md

[DonovanChan]

CHANGE LOG

• Update link to Mocha
• Update link to Docker Toolbox

NOTES

Is Docker Machine still required over the newer Docker Desktop? It would help to be explicit about that or update the instructions for Docker Desktop.

I'm not sure about Docker Desktop because I'm seeing 9 failures in the integration tests using node 10.16.0.

[astormnewrelic]

@DonovanChan First -- thank you for the PR and for the link fixes! Apologies for the unintentional 404s and we hope you didn't spend too much time googling around for the right links.

Second -- Docker Desktop should be sufficient and (at the point) likely the preferred/easier method for getting docker containers up and running on your windows/mac computers.

Third -- we're sorting through some internal/external travis issues at the moment -- but integration tests should be running clean. What sort of errors are you seeing?

[DonovanChan]

The errors all seem to relate to restify and SSL.

test/integration/collector-remote-method.tap.js ...(node:45349) [DEP0097] DeprecationWarning: Using a domain property in MakeCallback is deprecated. Use the async_context variant of MakeCallback or the AsyncResource class instead.
test/integration/collector-remote-method.tap.js ....... 0/3
  DataSender (callback style) talking to fake collector
  not ok error:0909006C:PEM routines:get_name:no start line
    stack: |
      new Server (node_modules/restify/lib/server.js:276:29)
      Object.createServer (node_modules/restify/lib/index.js:143:14)
      bootstrap (test/lib/fake-collector.js:292:24)
      Test.tap.test (test/integration/collector-remote-method.tap.js:26:3)
    at:
      line: 135
      column: 17
      file: _tls_common.js
      function: Object.createSecureContext
    tapCaught: testFunctionThrow
    test: DataSender (callback style) talking to fake collector

  remote method to preconnect > https with custom certificate
  not ok error:0909006C:PEM routines:get_name:no start line
    stack: |
      startMockCollector (test/integration/collector-remote-method.tap.js:99:26)
      Test.t.test (test/integration/collector-remote-method.tap.js:62:5)
    at:
      line: 135
      column: 17
      file: _tls_common.js
      function: Object.createSecureContext
    tapCaught: testFunctionThrow
    test: https with custom certificate

  remote method to preconnect > https with custom certificate
  not ok test count !== plan
    --- wanted
    +++ found
    -4
    +1
    results:
      ok: false
      count: 1
      pass: 0
      fail: 1
      bailout: false
      todo: 0
      skip: 0
      plan:
        start: 1
        end: 4
        skipAll: false
        skipReason: ''
        comment: ''
      failures:
        - ok: false
          id: 1
          name: 'error:0909006C:PEM routines:get_name:no start line'
          diag:
            stack: >
              startMockCollector
              (test/integration/collector-remote-method.tap.js:99:26)

              Test.t.test (test/integration/collector-remote-method.tap.js:62:5)
            at:
              line: 135
              column: 17
              file: _tls_common.js
              function: Object.createSecureContext
            tapCaught: testFunctionThrow
            test: https with custom certificate
          parent: remote method to preconnect > https with custom certificate

test/integration/proxy-api-connection.tap.js ..(node:46773) [DEP0097] DeprecationWarning: Using a domain property in MakeCallback is deprecated. Use the async_context variant of MakeCallback or the AsyncResource class instead.
test/integration/proxy-api-connection.tap.js ......... 8/10
  support ssl to the proxy
  not ok error:0909006C:PEM routines:get_name:no start line
    stack: |
      Test.tap.test (test/integration/proxy-api-connection.tap.js:20:35)
    at:
      line: 135
      column: 17
      file: _tls_common.js
      function: Object.createSecureContext
    tapCaught: testFunctionThrow
    test: support ssl to the proxy

  setting proxy_port should use the proxy agent
  not ok error:0909006C:PEM routines:get_name:no start line
    stack: |
      Test.tap.test (test/integration/proxy-api-connection.tap.js:64:35)
    at:
      line: 135
      column: 17
      file: _tls_common.js
      function: Object.createSecureContext
    tapCaught: testFunctionThrow
    test: setting proxy_port should use the proxy agent

test/integration/instrumentation/restify.tap.js ...... 7/11
  Restify should still be instrumented when run with SSL
  not ok error:0909006C:PEM routines:get_name:no start line
    stack: >
      Object.setDispatcher [as createServer]
      (lib/instrumentation/core/http.js:489:27)

      new Server (node_modules/restify/lib/server.js:276:29)

      Object.createServer (node_modules/restify/lib/index.js:143:14)

      Object.applyTrap [as apply] (lib/shim/shim.js:736:26)

      cb_withSSL (test/integration/instrumentation/restify.tap.js:64:29)

      fs.readFile (test/lib/agent_helper.js:350:11)
    at:
      line: 135
      column: 17
      file: _tls_common.js
      function: Object.createSecureContext
    test: Restify should still be instrumented when run with SSL

  Restify should still be instrumented when run with SSL
  not ok test count !== plan
    --- wanted
    +++ found
    -7
    +1
    results:
      ok: false
      count: 1
      pass: 0
      fail: 1
      bailout: false
      todo: 0
      skip: 0
      plan:
        start: 1
        end: 7
        skipAll: false
        skipReason: ''
        comment: ''
      failures:
        - ok: false
          id: 1
          name: 'error:0909006C:PEM routines:get_name:no start line'
          diag:
            stack: >
              Object.setDispatcher [as createServer]
              (lib/instrumentation/core/http.js:489:27)

              new Server (node_modules/restify/lib/server.js:276:29)

              Object.createServer (node_modules/restify/lib/index.js:143:14)

              Object.applyTrap [as apply] (lib/shim/shim.js:736:26)

              cb_withSSL (test/integration/instrumentation/restify.tap.js:64:29)

              fs.readFile (test/lib/agent_helper.js:350:11)
            at:
              line: 135
              column: 17
              file: _tls_common.js
              function: Object.createSecureContext
            test: Restify should still be instrumented when run with SSL
          parent: Restify should still be instrumented when run with SSL

  Restify should generate middleware metrics
  not ok Only one agent at a time! This one was created at:
    stack: |
      Object.loadMockedAgent (test/lib/agent_helper.js:61:24)
      Object.instrumentMockedAgent (test/lib/agent_helper.js:129:26)
      cb_withSSL (test/integration/instrumentation/restify.tap.js:62:28)
      fs.readFile (test/lib/agent_helper.js:350:11)
    at:
      line: 61
      column: 24
      file: test/lib/agent_helper.js
      function: Object.loadMockedAgent
    tapCaught: testFunctionThrow
    test: Restify should generate middleware metrics
    source: >
      _agent.__created = new Error('Only one agent at a time! This one was created
      at:')

  Restify should generate middleware metrics
  not ok test count !== plan
    --- wanted
    +++ found
    -5
    +1
    results:
      ok: false
      count: 1
      pass: 0
      fail: 1
      bailout: false
      todo: 0
      skip: 0
      plan:
        start: 1
        end: 5
        skipAll: false
        skipReason: ''
        comment: ''
      failures:
        - ok: false
          id: 1
          name: 'Only one agent at a time! This one was created at:'
          diag:
            stack: |
              Object.loadMockedAgent (test/lib/agent_helper.js:61:24)
              Object.instrumentMockedAgent (test/lib/agent_helper.js:129:26)
              cb_withSSL (test/integration/instrumentation/restify.tap.js:62:28)
              fs.readFile (test/lib/agent_helper.js:350:11)
            at:
              line: 61
              column: 24
              file: test/lib/agent_helper.js
              function: Object.loadMockedAgent
            tapCaught: testFunctionThrow
            test: Restify should generate middleware metrics
            source: >
              _agent.__created = new Error('Only one agent at a time! This one was
              created at:')
          parent: Restify should generate middleware metrics

[carlo-808]

Thank you for your PR, @DonovanChan . We have updated the documentation based on your suggestions and the changes should be coming in the next agent release.