Flatten mask in display_matrix #480
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gonzaponte
approved these changes
Jun 10, 2018
#480 [author: jjgomezcadenas] The display function display_matrix takes an optional mask array that allows to plot only those values of the matrix accepted by the mask. This feature had not been previously tested, and thus we had not noted that the mask had to be flattened. This is now fixed. [reviewer: gonzaponte] Straightforward fix. Approved.
gonzaponte
changed the title
jacg
pushed a commit
to jacg/IC
that referenced
this pull request
Sep 14, 2018
next-exp#480 [author: jjgomezcadenas] The display function display_matrix takes an optional mask array that allows to plot only those values of the matrix accepted by the mask. This feature had not been previously tested, and thus we had not noted that the mask had to be flattened. This is now fixed. [reviewer: gonzaponte] Straightforward fix. Approved.
jmbenlloch
pushed a commit
to jmbenlloch/IC-1
that referenced
this pull request
Oct 16, 2018
next-exp#480 [author: jjgomezcadenas] The display function display_matrix takes an optional mask array that allows to plot only those values of the matrix accepted by the mask. This feature had not been previously tested, and thus we had not noted that the mask had to be flattened. This is now fixed. [reviewer: gonzaponte] Straightforward fix. Approved.
jmbenlloch
pushed a commit
to jmbenlloch/IC-1
that referenced
this pull request
Oct 16, 2018
next-exp#480 [author: jjgomezcadenas] The display function display_matrix takes an optional mask array that allows to plot only those values of the matrix accepted by the mask. This feature had not been previously tested, and thus we had not noted that the mask had to be flattened. This is now fixed. [reviewer: gonzaponte] Straightforward fix. Approved.
jmbenlloch
pushed a commit
to jmbenlloch/IC-1
that referenced
this pull request
Oct 16, 2018
next-exp#480 [author: jjgomezcadenas] The display function display_matrix takes an optional mask array that allows to plot only those values of the matrix accepted by the mask. This feature had not been previously tested, and thus we had not noted that the mask had to be flattened. This is now fixed. [reviewer: gonzaponte] Straightforward fix. Approved.
jmbenlloch
pushed a commit
that referenced
this pull request
Oct 16, 2018
#480 [author: jjgomezcadenas] The display function display_matrix takes an optional mask array that allows to plot only those values of the matrix accepted by the mask. This feature had not been previously tested, and thus we had not noted that the mask had to be flattened. This is now fixed. [reviewer: gonzaponte] Straightforward fix. Approved.
jmbenlloch
pushed a commit
to jmbenlloch/IC-1
that referenced
this pull request
Oct 16, 2018
next-exp#480 [author: jjgomezcadenas] The display function display_matrix takes an optional mask array that allows to plot only those values of the matrix accepted by the mask. This feature had not been previously tested, and thus we had not noted that the mask had to be flattened. This is now fixed. [reviewer: gonzaponte] Straightforward fix. Approved.
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The display function
display_matrixtakes an optional mask array that allows to plot only those values of the matrix accepted by the mask. This feature had not been previously tested, and thus we had not noted that the mask had to be flattened. This is now fixed.