Use IC io load_dst instead of pandas read_hdf to load PSFs
#714
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I think this PR can be approved, however, annoyingly, Travis failed... @jmbenlloch can you maybe restart Travis build so hopefully it will not fail and we could merge it? |
mmkekic
approved these changes
Apr 9, 2020
Done to avoid compatibility issues between pandas versions
bpalmeiro
force-pushed
the
psf_fix_beersheba
branch
from
069c799
to
4a41eb9
Compare
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The use of
read_hdffunction as it is fails in higher pandas versions. This uses the standard IC function to load dataframes to discouple the version problem frombeershebacity.