New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Fix non-interpolated deconvolution #906

Open

gonzaponte wants to merge 7 commits into next-exp:master from gonzaponte:fix-deconv-no-interpolation

Collaborator

gonzaponte commented Oct 23, 2024

The output of the deconvolution without interpolation produces an image with a different size than with interpolation.

Fixes #905.

gonzaponte force-pushed the fix-deconv-no-interpolation branch 3 times, most recently from 908e2ab to 768e49c Compare

October 30, 2024 10:22

jwaiton reviewed

View reviewed changes

invisible_cities/reco/deconv_functions_test.py Outdated Show resolved Hide resolved

jwaiton reviewed

View reviewed changes

invisible_cities/reco/deconv_functions_test.py Outdated Show resolved Hide resolved

jwaiton reviewed

View reviewed changes

invisible_cities/reco/deconv_functions_test.py Outdated Show resolved Hide resolved

jwaiton reviewed

View reviewed changes

invisible_cities/reco/deconv_functions_test.py Outdated Show resolved Hide resolved

jwaiton reviewed

View reviewed changes

invisible_cities/reco/deconv_functions.py Show resolved Hide resolved

jwaiton reviewed

View reviewed changes

invisible_cities/reco/deconv_functions.py Show resolved Hide resolved

gonzaponte commented

View reviewed changes

Collaborator Author

gonzaponte left a comment

I've tried to reply as a review to reduce the amount of notifications. Let's see how it works.

invisible_cities/reco/deconv_functions.py Show resolved Hide resolved

invisible_cities/reco/deconv_functions.py Show resolved Hide resolved

invisible_cities/reco/deconv_functions_test.py Outdated Show resolved Hide resolved

invisible_cities/reco/deconv_functions_test.py Outdated Show resolved Hide resolved

invisible_cities/reco/deconv_functions_test.py Outdated Show resolved Hide resolved

jwaiton approved these changes

View reviewed changes

Collaborator

jwaiton left a comment

This PR resolves a difficult to spot issue within the interpolation and improves the clarity of the interpolation process in beersheba. Good work! 👍

gonzaponte added 7 commits

November 7, 2024 15:36


          Test all interpolation methods in deconv_functions

58d325a


          Refactor and fix deconvolution_input for the case of no interpolation

d10a611

The no-interpolation case did not generate images with the same size
as the other interpolation methods.


          Remove deprecated test

422783f


          Explain tests in docstrings

d00d458


          Refactor test_deconvolution_input_interpolation_method

b01007b


          Extract data preparation into a fixture

f41676c


          Recover test_deconvolution_input_wrong_interpolation_method_raises

850f8b5

gonzaponte force-pushed the fix-deconv-no-interpolation branch from d7ccefc to 850f8b5 Compare

November 7, 2024 14:36

# for free to join this conversation on GitHub. Already have an account? # to comment

Labels

None yet