Step2 - 볼링 점수판(그리기) #993
Open
Step2 - 볼링 점수판(그리기) #993
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
javajigi
requested changes
Nov 22, 2022
| @@ -0,0 +1,16 @@ | |||
| package bowling.domain; | |||
|
|
|||
| public interface Frame { | |||
There was a problem hiding this comment.
인터페이스에 메서드 수가 너무 많다.
메서드 수를 줄일 수 있는 방법을 찾아보면 어떨까?
Comment on lines
+7
to
+9
| FrameStatus getFirstStatus(); | ||
| FrameStatus getSecondStatus(); | ||
| FrameStatus getThirdStatus(); |
There was a problem hiding this comment.
State getState()와 같이 하나로 합쳐서 구현해 보는 것은 어떨까?
Comment on lines
+7
to
+9
|
|
||
|
|
||
| public Hit(int hit) { |
| } | ||
|
|
||
| @Override | ||
| public FrameStatus getThirdStatus() { |
There was a problem hiding this comment.
각 상태에 따른 if 문이 너무 많다.
자바의 다형성을 적용해 if문을 최소화하도록 도전해 보면 어떨까?
| @@ -0,0 +1,83 @@ | |||
| package bowling.domain; | |||
|
|
|||
| public class NormalFrame implements Frame { | |||
There was a problem hiding this comment.
NormalFrame과 FinalFrame을 보면 중복 코드가 많다.
AbstractFrame과 같은 객체를 추가해 NormalFrame과 FinalFrame의 중복 로직을 제거해 보면 어떨까?
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.