Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

refactor: Use public-share aware functions from @nextcloud/files and @nextcloud/sharing #1245

Merged
merged 1 commit into from
Jun 21, 2024

Conversation

susnux
Copy link
Contributor

@susnux susnux commented Jun 20, 2024

No description provided.

@susnux susnux added the 3. to review Waiting for reviews label Jun 20, 2024
@susnux susnux requested review from skjnldsv and Pytal June 20, 2024 14:05
@susnux susnux force-pushed the refactor/public-share branch from af2dc7b to 3a6ff14 Compare June 21, 2024 09:44
@susnux susnux requested a review from artonge June 21, 2024 09:44
…stead of custom

Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
@susnux susnux force-pushed the refactor/public-share branch from 3a6ff14 to 8bd79ea Compare June 21, 2024 19:19
@susnux susnux merged commit c7735bd into main Jun 21, 2024
16 checks passed
@susnux susnux deleted the refactor/public-share branch June 21, 2024 19:35
@susnux susnux mentioned this pull request Jun 21, 2024
@Antreesy
Copy link
Contributor

Antreesy commented Jul 8, 2024

const source = join(davRemoteURL, davRootPath)

added join() method returns incorrect source in case of Talk upload:

image
image

see https:/ protocol with a single slash @susnux

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
3. to review Waiting for reviews
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants