Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

feat: Add uploadConflictHandler to handle conflict resolution #1442

Merged
merged 2 commits into from
Oct 17, 2024

Conversation

susnux
Copy link
Contributor

@susnux susnux commented Oct 16, 2024


Move logic from upload picker into reusable utilities.

I think this helps by making the component smaller, thus better maintainable due to less complexity, and allowing to reuse the logic if needed (working on #617 ).

Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
@susnux susnux added enhancement New feature or request 3. to review Waiting for reviews labels Oct 16, 2024
@susnux susnux requested review from skjnldsv and Pytal October 16, 2024 13:51
…adable (smaller)

Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
Copy link

codecov bot commented Oct 16, 2024

Bundle Report

Changes will decrease total bundle size by 1.12kB (-0.15%) ⬇️. This is within the configured threshold ✅

Detailed changes
Bundle name Size Change
@nextcloud/upload-esm 376.98kB 701 bytes (-0.19%) ⬇️
@nextcloud/upload-esm-cjs 380.33kB 420 bytes (-0.11%) ⬇️

Base automatically changed from test/cleanup to main October 17, 2024 06:24
@skjnldsv skjnldsv merged commit b73b7a2 into main Oct 17, 2024
17 checks passed
@skjnldsv skjnldsv deleted the feat/conflict-handler branch October 17, 2024 06:25
@skjnldsv skjnldsv mentioned this pull request Nov 13, 2024
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
3. to review Waiting for reviews enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants