feat: add upload menu shortcuts #1529
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: skjnldsv <skjnldsv@protonmail.com>
Signed-off-by: skjnldsv <skjnldsv@protonmail.com>
skjnldsv
added
enhancement
This comment was marked as resolved.
This comment was marked as resolved.
skjnldsv
force-pushed
the
feat/keyboard-shortcut
branch
from
b6f978a to
ec7069e
Compare
skjnldsv
force-pushed
the
feat/keyboard-shortcut
branch
from
ec7069e to
9ec5f71
Compare
skjnldsv
commented
Dec 18, 2024
| @@ -32,38 +32,11 @@ window._oc_capabilities = { files: {} } | |||
|
|
|||
| // Example use: | |||
| // cy.mount(MyComponent) | |||
| Cypress.Commands.add('mount', (component, optionsOrProps) => { | |||
There was a problem hiding this comment.
See Ferdinand's comment on this: nextcloud/server#48725 (comment)
skjnldsv
commented
Dec 18, 2024
Comment on lines
+491
to
+507
| onKeyDown(event: KeyboardEvent) { | ||
| // Shift + u opens the menu | ||
| if (event.key === 'u') { | ||
| // If we have a menu, open it | ||
| if (this.haveMenu) { | ||
| this.openedMenu = true | ||
| return | ||
| } | ||
|
|
||
| // Otherwise, trigger the default action | ||
| this.onTriggerPick() | ||
| } | ||
|
|
||
| if (event.key === 'Escape' && this.openedMenu) { | ||
| this.openedMenu = false | ||
| } | ||
| }, |
There was a problem hiding this comment.
The important part
nfebe
approved these changes
Dec 18, 2024
Signed-off-by: skjnldsv <skjnldsv@protonmail.com>
Signed-off-by: skjnldsv <skjnldsv@protonmail.com>
skjnldsv
force-pushed
the
feat/keyboard-shortcut
branch
from
9ec5f71 to
42269c4
Compare
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Subset of nextcloud/server#30484
Follow-up of nextcloud/server#49432