Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

fix(uploader): Correctly (re)set progress on upload #1603

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

susnux
Copy link
Contributor

@susnux susnux commented Feb 21, 2025

On upload event we should also update the uploaded bytes for chunked uploads.
Moreover we need to reset the uploaded bytes when a retry occures as the progress bar is otherwise showing the wrong ETA.

Basically:

  • on progress event: Update the uploaded bytes to 90% of it (we reserve 10% until the request finished)
  • on response we add that 10% reserved bytes (so the server responded with OK -> mark the chunk / upload as 100% done)
  • on retry we reset the uploaded bytes for that chunk

On upload event we should also update the uploaded bytes for chunked
uploads.
Moreover we need to reset the uploaded bytes when a retry occures as the
progress bar is otherwise showing the wrong ETA.

Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
@susnux susnux added bug Something isn't working 3. to review Waiting for reviews labels Feb 21, 2025
@susnux susnux requested review from artonge and skjnldsv February 21, 2025 15:04
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
3. to review Waiting for reviews bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant