Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

fix(tests): ssrBuild was renamed to isSsrBuild #168

Merged
merged 1 commit into from
Apr 21, 2024
Merged

fix(tests): ssrBuild was renamed to isSsrBuild #168

merged 1 commit into from
Apr 21, 2024

Conversation

susnux
Copy link
Contributor

@susnux susnux commented Apr 21, 2024

No description provided.

@susnux
fix(tests): ssrBuild was renamed to isSsrBuild
752aff3 
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
@susnux susnux added type: bug 🐛 Something isn't working 3. to review 3️⃣ Waiting for reviews labels Apr 21, 2024
@susnux susnux requested review from ShGKme and Antreesy April 21, 2024 16:19
ShGKme
ShGKme approved these changes Apr 21, 2024
View reviewed changes
Copy link
Contributor

@ShGKme ShGKme left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

https://vitejs.dev/guide/migration.html#advanced

@susnux
Copy link
Contributor Author

susnux commented Apr 21, 2024

Yes, we only use it for the tests :)

@susnux susnux merged commit 6481e64 into main Apr 21, 2024
12 checks passed
@susnux susnux deleted the fix/ssr-option branch April 21, 2024 16:27
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@ShGKme ShGKme ShGKme approved these changes

@Antreesy Antreesy Awaiting requested review from Antreesy

Assignees
No one assigned
Labels
3. to review 3️⃣ Waiting for reviews type: bug 🐛 Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@susnux @ShGKme