-
Notifications
You must be signed in to change notification settings - Fork 67
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Remove horizontal scrolling for activity view #1483
Remove horizontal scrolling for activity view #1483
Conversation
/backport to stable28 |
/compile amend / |
323d654
to
5c1e05b
Compare
5c1e05b
to
6b118dd
Compare
/compile amend / |
6b118dd
to
42d5306
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested on my local dev env, works, and LGTM!
42d5306
to
d0830ee
Compare
/compile amend / |
d0830ee
to
1ac7d3e
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Doesn't this solution crops the content of the activity if it overflows?
1ac7d3e
to
4f5852b
Compare
1 flaky test on run #1077 ↗︎Details:
|
Test | Artifacts | |
---|---|---|
Check activity listing in the sidebar > Has move activity |
Test Replay
Screenshots
|
Review all test suite changes for PR #1483 ↗︎
4f5852b
to
8a7ab04
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All i've changed for this PR were 2 lines of css. This is a problem, but not related to PR |
/compile amend |
Signed-off-by: julia.kirschenheuter <julia.kirschenheuter@nextcloud.com> Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>
8a7ab04
to
d8fab4f
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry for the confusion on my end, LGTM!
The backport to stable28 failed. Please do this backport manually. # Switch to the target branch and update it
git checkout stable28
git pull origin stable28
# Create the new backport branch
git checkout -b fix/foo-stable28
# Cherry pick the change from the commit sha1 of the change against the default branch
# This might cause conflicts. Resolve them.
git cherry-pick abc123
# Push the cherry pick commit to the remote repository and open a pull request
git push origin fix/foo-stable28 Error: Unknown error More info at https://docs.nextcloud.com/server/latest/developer_manual/getting_started/development_process.html#manual-backport |
Hello there, We hope that the review process is going smooth and is helpful for you. We want to ensure your pull request is reviewed to your satisfaction. If you have a moment, our community management team would very much appreciate your feedback on your experience with this PR review process. Your feedback is valuable to us as we continuously strive to improve our community developer experience. Please take a moment to complete our short survey by clicking on the following link: https://cloud.nextcloud.com/apps/forms/s/i9Ago4EQRZ7TWxjfmeEpPkf6 Thank you for contributing to Nextcloud and we hope to hear from you soon! |
Resolves #1480
🖼️ Screenshots