Only Download Necessary Files

[alperozturk96]

• Tests written, or not not needed

Problem

Downloaded files are re-downloading, and notifications appear for files that have already been downloaded. The sync should only trigger downloads for new or editable files, as media files cannot be changed.

The two-way sync triggers the FileDownloadWorker every 15 minutes. If a folder contains multiple files, even if all files are already downloaded, the worker will still show notifications for each file and attempt to re-download them again.

Note: Images can be edited, but any edited image will create a copy rather than modifying the original file. Thus, no need to download original image.

Changes

• Download only files that haven't been downloaded and aren't media files.
• Return early if requestDownloads is empty.

Demo

test.mp4

[github-actions]

Codacy

Lint

Type	master	PR
Warnings	59	59
Errors	3	3

SpotBugs

Category	Base	New
Bad practice	64	64
Correctness	63	63
Dodgy code	296	296
Experimental	1	1
Internationalization	7	7
Malicious code vulnerability	1	1
Multithreaded correctness	6	6
Performance	53	53
Security	18	18
Total	509	509

[tobiasKaminsky]

Can you explain reason behind filtering media files?

This worker is also used when exporting files (FilesExportWork.kt), so this would then not work if you want to export a pdf file?

[tobiasKaminsky]

see comment

[alperozturk96]

Can you explain reason behind filtering media files?

This worker is also used when exporting files (FilesExportWork.kt), so this would then not work if you want to export a pdf file?

FilesExportWork only triggers the FileDownloadWorker when a file hasn’t been downloaded, so the filter introduced in this PR won’t be applied.

Here’s a demo of FilesExportWork with already downloaded files.

exp.mp4

You can check the PR description for more details on the purpose of this PR.

#13683 (comment)

[fegauthier]

I'm eagerly waiting for this PR. I have a Google Pixel 8, and files are constantly resyncing every 15 minutes. It drains the battery significantly and uses bandwidth unnecessarily. Do you guys know when it will be merged?

Thanks.

[alperozturk96]

Not Valid after: #13897