Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Top titlebar is too high and leaving a gap to the bar below #1426

Closed
arnowelzel opened this issue Aug 18, 2024 · 3 comments · Fixed by #1430
Closed

Top titlebar is too high and leaving a gap to the bar below #1426

arnowelzel opened this issue Aug 18, 2024 · 3 comments · Fixed by #1430
Labels
1. to develop bug Something isn't working

Comments

@arnowelzel
Copy link

Describe the bug
The title bar is positioned too high and thus leaving a blank space to the next line where the content is displayed when scrolling a page up.

To Reproduce
Steps to reproduce the behavior:

  1. Create a page.
  2. Add enough content that scrolling is neccessary.
  3. Scroll the page up
  4. See the text from the page displayed partly between the top title bar and the document info/edit bar.

Expected behavior
The title bar is positioned correctly.

Screenshots

Page in view mode:

image

Page in edit mode:

image

Server details:

  • Collectives app version: 2.13.0
  • Nextcloud version: 29.0.3
  • PHP Version: 8.3
  • Database: MariaDB 10.6

Client details:

  • OS: Windows 11
  • Browser: Firefox, Chrome, Vivaldi, Edge
  • Browser version: latest versions as of 2024-08-18
  • Device: desktop
Logs

Nextcloud log (data/nextcloud.log)

(not relevant)

Browser log

@arnowelzel arnowelzel added the bug Something isn't working label Aug 18, 2024
@arnowelzel arnowelzel changed the title Top titlebar is too high and leaving a gap to the author info Top titlebar is too high and leaving a gap to the bar below Aug 18, 2024
@mejo-
Copy link
Member

mejo- commented Aug 20, 2024

Hey @arnowelzel, thanks for the report. This got fixed with the latest 2.14.0 release of Collectives.

@mejo- mejo- closed this as completed Aug 20, 2024
@arnowelzel
Copy link
Author

Ok, there is no visible text any longer. But the bar is still higher as it should be. In older versions, there was an 8px padding to the top, now it still looks like the bar is nearly stuck at the top border - this is the original reason, why the text was visible at all:

image

Just moving that to to 8px padding from the top would have fixed it as well.

For comparison - the "Search" box on the left is also not that close to the border:

image

I fixed this by applying a custom style in my own instance:

.app-collectives #titleform {
  padding-top: 8px !important
}

Result:

image

mejo- added a commit that referenced this issue Aug 20, 2024
Fixes: #1426

Signed-off-by: Jonas <jonas@freesources.org>
@mejo-
Copy link
Member

mejo- commented Aug 20, 2024

Thanks @arnowelzel. The reason for the title bar being too close to the top header bar is some refactoring that was necessary for the Nextcloud 30 design changes. I've pushed a fix in #1430.

mejo- added a commit that referenced this issue Aug 21, 2024
Fixes: #1426

Signed-off-by: Jonas <jonas@freesources.org>
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
1. to develop bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants