Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Replace "open the location" behaviour with "open the file" one #249

Open
ostasevych opened this issue Dec 6, 2023 · 4 comments
Open

Replace "open the location" behaviour with "open the file" one #249

ostasevych opened this issue Dec 6, 2023 · 4 comments

Comments

@ostasevych
Copy link

ostasevych commented Dec 6, 2023

Typically, when searched for some document with the help of the universal search the document is opened, but not the location.
However, in case of fulltext search the location is opened.

Would that be possible to make the approach universal?

My suggestion:
in lib/Service/SearchService.php:

345 $this->urlGenerator->linkToRoute('files.view.index', ['dir' => $this->withoutEndSlash($dir), 'openfile' => $document->getId(), 'scrollto' => $filename])
@ostasevych ostasevych changed the title Replace open the location behaviour with open the file Replace "open the location" behaviour with "open the file" one Dec 6, 2023
ostasevych added a commit to ostasevych/files_fulltextsearch that referenced this issue Dec 7, 2023
Typically, when searched for some document with the help of the universal search the document is opened, but not the location.

This PR will allow open files directly from the results of the search.

See nextcloud#249

Signed-off-by: Oleksa <ostasevych@users.noreply.github.com>
@XueSheng-GIT
Copy link

XueSheng-GIT commented Feb 4, 2024

I've updated to NC 28.0.2 and it seems that "scrollto" does not work anymore. Once you click on a file found via global search (fulltextsearch), just the directory itself is opened (but the file is not highlighted and scrollto does not work).

@XueSheng-GIT
Copy link

#253 is marked as merged but this patch is still missing for files_fulltextsearch 29.0.0. Any plan to release?

@moritz76
Copy link

Hi,

It still does not work. When a user searches with full text search and clicks on a document, only the folder is opened, not the document,

@moritz76
Copy link

moritz76 commented Jan 9, 2025

Hi,

any progress on this?

# for free to join this conversation on GitHub. Already have an account? # to comment
Projects
None yet
Development

No branches or pull requests

4 participants