Fix saving annotations in paths with special characters #1151
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@nextcloud/paths was already an implicit dependency, but now it is made explicit to use the functions it provides in the PDF viewer code. Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
The filename may contain characters that are not compatible with a URL path, so it needs to be explicitly encoded. Otherwise the upload could fail (for example, if the filename contains "%" followed by a letter, which would cause the server to fail to decode the path and return a "400 Bad request" error) or even overwrite a different file (for example, if the filename contains "#", which would cause the rest of the path to be ignored). Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
|
/compile / |
|
/backport to stable31 |
|
/backport to stable30 |
|
/backport to stable29 |
Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1102
The filename may contain characters that are not compatible with a URL path, so it needs to be explicitly encoded. Otherwise the upload could fail (for example, if the filename contains
%followed by a letter, which would cause the server to fail to decode the path and return a400 Bad requesterror) or even overwrite a different file (for example, if the filename contains#, which would cause the rest of the path to be ignored).How to test (scenario 1)
testtest#folderResult with this pull request
The annotation is in the file
Result without this pull request
The annotation is not in the file. If the root folder is opened again there is now a file named
testin it.How to test (scenario 2)
#testResult with this pull request
The file is saved
Result without this pull request
An error is shown and the file is not saved. The "Network" tab of the browser development tools show that the request failed with "409 Conflict" (as it tried to overwrite the root folder).
How to test (scenario 3)
test%folderResult with this pull request
The file is saved
Result without this pull request
An error is shown and the file is not saved. The "Network" tab of the browser development tools show that the request failed with "400 Bad request" (as
%fin the path could not be decoded).